Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: chrome/browser/resources/ntp4/new_tab.html

Issue 2647653002: Initially load new_tab.css with a timestamp for chrome://apps. (Closed)
Patch Set: Initially load new_tab.css with a timestamp for chrome://apps. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/ntp4/new_tab.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/ntp4/new_tab.html
diff --git a/chrome/browser/resources/ntp4/new_tab.html b/chrome/browser/resources/ntp4/new_tab.html
index 3ae53d5550673046fc9d2081fb77b4e530ba819e..513b4d268f008bf01a20e12caa3c78ed66ba5c26 100644
--- a/chrome/browser/resources/ntp4/new_tab.html
+++ b/chrome/browser/resources/ntp4/new_tab.html
@@ -28,8 +28,11 @@
<link rel="stylesheet" href="nav_dot.css">
<link rel="stylesheet" href="new_tab.css">
<link rel="stylesheet" href="tile_page.css">
-<link id="themecss" rel="stylesheet" href="chrome://theme/css/new_tab_theme.css">
Dan Beam 2017/01/19 23:18:54 maybe we could just use our new $i18n{} mechanism
rune 2017/01/19 23:38:51 Will that C++ string change on each load? I think
-
+<script>
+// Until themes can clear the cache, force-reload the theme stylesheet.
+document.write('<link id="themecss" rel="stylesheet" ' +
+ 'href="chrome://theme/css/new_tab_theme.css?' + Date.now() + '">');
Dan Beam 2017/01/21 02:05:56 80 col wrap
+</script>
Dan Beam 2017/01/19 23:18:54 i thought CSP prevented inline scripts from runnin
rune 2017/01/19 23:38:51 Yes, it seems so. This is copied from incognito_ta
<script src="../../../../ui/webui/resources/js/action_link.js"></script>
<script src="../../../../ui/webui/resources/js/event_tracker.js"></script>
<script src="../../../../ui/webui/resources/js/util.js"></script>
« no previous file with comments | « no previous file | chrome/browser/resources/ntp4/new_tab.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698