Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 2647623002: Added CSSPropertyBackgroundComponentUtils which holds background component parsing methods. (Closed)

Created:
3 years, 11 months ago by nainar
Modified:
3 years, 10 months ago
Reviewers:
aazzam
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added CSSPropertyBackgroundComponentUtils which holds background component parsing methods. Moved methods with background component parsing logic into a utils file, so that the parsing logic for CSSPropertyBackgroundAttachment, CSSPropertyBackgroundBlendMode, CSSPropertyBackgroundClip, CSSPropertyBackgroundImage, CSSPropertyBackgroundOrigin, CSSPropertyBackgroundPositionX, CSSPropertyBackgroundPositionY, CSSPropertyBackgroundSize, CSSPropertyMaskSourceType, CSSPropertyWebkitBackgroundClip, CSSPropertyWebkitBackgroundOrigin, CSSPropertyWebkitMaskClip, CSSPropertyWebkitMaskComposite, CSSPropertyWebkitMaskImage, CSSPropertyWebkitMaskOrigin, CSSPropertyWebkitMaskPositionX, CSSPropertyWebkitMaskPositionY and CSSPropertyWebkitMaskSize can be moved out of CSSPropertyParser.cpp into implementations of CSSPropertyAPI.h. Follow up patches implement CSSPropertyAPI for all the properties. This patch: - Adds CSSPropertyBackgroundComponentUtils (.h and .cpp files) to the BUILD.gn file. - Moves consumeBackgroundBlendMode(), consumeBackgroundAttachment(), consumeBackgroundBox(), consumeBackgroundComposite(), consumeMaskSourceType(), consumePrefixedBackgroundBox(), consumeBackgroundSize(), addBackgroundValue() and consumeBackgroundComponent() from CSSPropertyParser.cpp to CSSPropertyBackgroundComponentUtils.cpp. - Changes callsites of these methods in CSSPropertyParser.cpp to call the methods from CSSPropertyBackgroundComponentUtils. BUG=668012

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -143 lines) Patch
M third_party/WebKit/Source/core/css/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 9 chunks +23 lines, -143 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyBackgroundComponentUtils.h View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyBackgroundComponentUtils.cpp View 1 1 chunk +162 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (9 generated)
nainar
3 years, 11 months ago (2017-01-19 06:16:34 UTC) #4
Anna, 

PTAL? Thanks!

Powered by Google App Engine
This is Rietveld 408576698