Added CSSPropertyPositionUtils which holds position parsing methods.

Added CSSPropertyPositionUtils which holds position parsing methods.

Moved methods with position parsing logic into a utils file, so that
the parsing logic for CSSPropertyBackgroundAttachment,
CSSPropertyBackgroundBlendMode, CSSPropertyBackgroundClip,
CSSPropertyBackgroundImage, CSSPropertyBackgroundOrigin,
CSSPropertyBackgroundPositionX, CSSPropertyBackgroundPositionY,
CSSPropertyBackgroundSize, CSSPropertyMaskSourceType,
CSSPropertyWebkitBackgroundClip, CSSPropertyWebkitBackgroundOrigin,
CSSPropertyWebkitMaskClip, CSSPropertyWebkitMaskComposite,
CSSPropertyWebkitMaskImage, CSSPropertyWebkitMaskOrigin,
CSSPropertyWebkitMaskPositionX, CSSPropertyWebkitMaskPositionY and
CSSPropertyWebkitMaskSize can be moved out of
CSSPropertyParser.cpp into implementations of CSSPropertyAPI.h.

Follow up patches implement CSSPropertyAPI for all the properties.

This patch:
- Adds CSSPropertyPositionUtils (.h and .cpp files) to the BUILD.gn
  file.
- Moves consumePositionLonghand(), consumePositionX() and
  consumePositionY() from CSSPropertyParser.cpp to
  CSSPropertyPositionUtils.cpp.
- Changes callsites of these methods in CSSPropertyParser.cpp to call
  the methods from CSSPropertyPositionUtils.

BUG=668012
Review-Url: https://codereview.chromium.org/2647503004
Cr-Commit-Position: refs/heads/master@{#445031}
Committed: https://chromium.googlesource.com/chromium/src/+/6cb44cd8daf1700acb3cc710191974d2c057a4ba

[nainar, 2017-01-19 05:19:46]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 05:20:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-01-19 05:25:11]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 05:25:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-01-19 05:58:09]

nainar@chromium.org changed reviewers:
+ aazzam@google.com

[nainar, 2017-01-19 05:58:10]

Anna, 

PTAL?

[commit-bot: I haz the power, 2017-01-19 07:23:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 07:23:30]

Dry run: This issue passed the CQ dry run.

[aazzam, 2017-01-19 22:36:18]

if consumePositionLonghand is only a helper function for consumePositionX and
consumePositionY, then maybe just implement this in the API, and then in the API
files for CSSPropertyWebkit[Transform|Perspective]Origin[X|Y] you can just have
consumePositionX and consumePositionY logic, calling consumePositionLonghand
from the utils file? since as far as i can see, consumePosition[X|Y] will each
be used by only one API file? :)

let me know if i've misunderstood the changes haha :)

[nainar, 2017-01-20 04:23:07]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 04:23:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-01-20 04:24:31]

Done. PTAL?

[commit-bot: I haz the power, 2017-01-20 04:25:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 04:25:09]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[aazzam, 2017-01-20 04:36:52]

aazzam@google.com changed reviewers:
+ sashab@chromium.org

[aazzam, 2017-01-20 04:36:53]

awesome, LGTM! sasha ptal :)

[sashab, 2017-01-20 04:39:49]

Might need to replace forward decls with #inclueds. Other than that lgtm :)

https://codereview.chromium.org/2647503004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/BUILD.gn (right):

https://codereview.chromium.org/2647503004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/BUILD.gn:395:
"properties/CSSPropertyPositionUtils.h",
Missing CSSPropertyPositionUtils.cpp :)

https://codereview.chromium.org/2647503004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/BUILD.gn:395:
"properties/CSSPropertyPositionUtils.h",
Missing CSSPropertyPositionUtils.cpp :)

https://codereview.chromium.org/2647503004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/properties/CSSPropertyPositionUtils.h
(right):

https://codereview.chromium.org/2647503004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyPositionUtils.h:15:
class CSSValue;
I'm surprised this builds. I'm pretty sure you need to #include
CSSPrimitiveValue since it needs to know CSSPrimitiveValue is a subclass of
CSSValue. Same with CSSParserTokenRange -- since the implementation is in this
file, you need to #include the .h file.

[nainar, 2017-01-20 06:22:38]

Sasha FYI.

https://codereview.chromium.org/2647503004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/BUILD.gn (right):

https://codereview.chromium.org/2647503004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/BUILD.gn:395:
"properties/CSSPropertyPositionUtils.h",
On 2017/01/20 at 04:39:49, sashab wrote:
> Missing CSSPropertyPositionUtils.cpp :)

Templated functions need to be defined need to be in the h file. Which is why
the function is in the h file and we have no cpp file to include. :P

https://codereview.chromium.org/2647503004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/properties/CSSPropertyPositionUtils.h
(right):

https://codereview.chromium.org/2647503004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyPositionUtils.h:15:
class CSSValue;
It builds locally for sure. Maybe its getting included in via some import?

[nainar, 2017-01-20 07:25:58]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 07:26:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 09:45:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 09:45:18]

Dry run: This issue passed the CQ dry run.

[nainar, 2017-01-20 10:22:20]

The CQ bit was checked by nainar@chromium.org

[nainar, 2017-01-20 10:22:20]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org,
aazzam@google.com
Link to the patchset: https://codereview.chromium.org/2647503004/#ps60001
(title: "Merged correctly")

[commit-bot: I haz the power, 2017-01-20 10:22:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 10:26:24]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484907740109280,
"parent_rev": "0eef9663b8fd5df8e56609d190f8c628387cd017", "commit_rev":
"6cb44cd8daf1700acb3cc710191974d2c057a4ba"}

[commit-bot: I haz the power, 2017-01-20 10:26:53]

Description was changed from

==========
Added CSSPropertyPositionUtils which holds position parsing methods.

Moved methods with position parsing logic into a utils file, so that
the parsing logic for CSSPropertyBackgroundAttachment,
CSSPropertyBackgroundBlendMode, CSSPropertyBackgroundClip,
CSSPropertyBackgroundImage, CSSPropertyBackgroundOrigin,
CSSPropertyBackgroundPositionX, CSSPropertyBackgroundPositionY,
CSSPropertyBackgroundSize, CSSPropertyMaskSourceType,
CSSPropertyWebkitBackgroundClip, CSSPropertyWebkitBackgroundOrigin,
CSSPropertyWebkitMaskClip, CSSPropertyWebkitMaskComposite,
CSSPropertyWebkitMaskImage, CSSPropertyWebkitMaskOrigin,
CSSPropertyWebkitMaskPositionX, CSSPropertyWebkitMaskPositionY and
CSSPropertyWebkitMaskSize can be moved out of
CSSPropertyParser.cpp into implementations of CSSPropertyAPI.h.

Follow up patches implement CSSPropertyAPI for all the properties.

This patch:
- Adds CSSPropertyPositionUtils (.h and .cpp files) to the BUILD.gn
  file.
- Moves consumePositionLonghand(), consumePositionX() and
  consumePositionY() from CSSPropertyParser.cpp to
  CSSPropertyPositionUtils.cpp.
- Changes callsites of these methods in CSSPropertyParser.cpp to call
  the methods from CSSPropertyPositionUtils.

BUG=668012
==========

to

==========
Added CSSPropertyPositionUtils which holds position parsing methods.

Moved methods with position parsing logic into a utils file, so that
the parsing logic for CSSPropertyBackgroundAttachment,
CSSPropertyBackgroundBlendMode, CSSPropertyBackgroundClip,
CSSPropertyBackgroundImage, CSSPropertyBackgroundOrigin,
CSSPropertyBackgroundPositionX, CSSPropertyBackgroundPositionY,
CSSPropertyBackgroundSize, CSSPropertyMaskSourceType,
CSSPropertyWebkitBackgroundClip, CSSPropertyWebkitBackgroundOrigin,
CSSPropertyWebkitMaskClip, CSSPropertyWebkitMaskComposite,
CSSPropertyWebkitMaskImage, CSSPropertyWebkitMaskOrigin,
CSSPropertyWebkitMaskPositionX, CSSPropertyWebkitMaskPositionY and
CSSPropertyWebkitMaskSize can be moved out of
CSSPropertyParser.cpp into implementations of CSSPropertyAPI.h.

Follow up patches implement CSSPropertyAPI for all the properties.

This patch:
- Adds CSSPropertyPositionUtils (.h and .cpp files) to the BUILD.gn
  file.
- Moves consumePositionLonghand(), consumePositionX() and
  consumePositionY() from CSSPropertyParser.cpp to
  CSSPropertyPositionUtils.cpp.
- Changes callsites of these methods in CSSPropertyParser.cpp to call
  the methods from CSSPropertyPositionUtils.

BUG=668012

Review-Url: https://codereview.chromium.org/2647503004
Cr-Commit-Position: refs/heads/master@{#445031}
Committed:
https://chromium.googlesource.com/chromium/src/+/6cb44cd8daf1700acb3cc7101919...
==========

[commit-bot: I haz the power, 2017-01-20 10:26:54]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6cb44cd8daf1700acb3cc7101919...