[Payments] Allow users enable and disable Android payment apps in payment request

Surface settings UIs to allow users enable and disable Android payment apps in payment request

The feature is disabled by default. It can be enabled via a flag:

  chrome://flags/#android-payment-apps

To test the new functionality:

  1) Install BobPayWithIsReadyPayService.apk:
     https://drive.google.com/a/google.com/file/d/0B3ISiXgGE1MNSnFXcnkwQ1FSbGc/view?usp=sharing
  2) Enable chrome://flags/#android-payment-apps.
  3) Go to setttings/Autofill and payments/Payment apps

BUG=679743
patch from issue 2636023002 at patchset 140001 (http://crrev.com/2636023002#ps140001)

Review-Url: https://codereview.chromium.org/2647573005
Cr-Commit-Position: refs/heads/master@{#446111}
Committed: https://chromium.googlesource.com/chromium/src/+/81942a0c2161cd39c04dac4368833f8f3ea556ea

[gogerald1, 2017-01-20 23:25:53]

Patchset #1 (id:1) has been deleted

[gogerald1, 2017-01-20 23:26:25]

Description was changed from

==========
format


format


surface settings UIs to allow users enable and disable Android payment apps in
payment request


Redesign Autofill settings UIs

BUG=679743

patch from issue 2636023002 at patchset 140001
(http://crrev.com/2636023002#ps140001)
==========

to

==========
Surface settings UIs to allow users enable and disable Android payment apps in
payment request

BUG=679743

patch from issue 2636023002 at patchset 140001
(http://crrev.com/2636023002#ps140001)
==========

[gogerald1, 2017-01-20 23:27:55]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[gogerald1, 2017-01-20 23:28:05]

The CQ bit was unchecked by gogerald@chromium.org

[gogerald1, 2017-01-21 00:37:53]

Patchset #1 (id:20001) has been deleted

[gogerald1, 2017-01-21 00:38:01]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-21 00:38:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 00:40:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 00:40:42]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[gogerald1, 2017-01-24 16:30:51]

Patchset #1 (id:40001) has been deleted

[gogerald1, 2017-01-24 16:30:57]

Patchset #1 (id:60001) has been deleted

[gogerald1, 2017-01-24 16:43:05]

Patchset #1 (id:80001) has been deleted

[gogerald1, 2017-01-24 16:45:08]

Description was changed from

==========
Surface settings UIs to allow users enable and disable Android payment apps in
payment request

BUG=679743

patch from issue 2636023002 at patchset 140001
(http://crrev.com/2636023002#ps140001)
==========

to

==========
Surface settings UIs to allow users enable and disable Android payment apps in
payment request

The feature is disabled by default. It can be enabled via a flag:

  chrome://flags/#android-payment-apps

To test the new functionality:

  1) Install BobPayWithIsReadyPayService.apk:
    
https://drive.google.com/a/google.com/file/d/0B3ISiXgGE1MNSnFXcnkwQ1FSbGc/vie...
  2) Enable chrome://flags/#android-payment-apps.
  3) Go to setttings/Autofill and payments/Payment apps

BUG=679743

patch from issue 2636023002 at patchset 140001
(http://crrev.com/2636023002#ps140001)
==========

[gogerald1, 2017-01-24 16:46:21]

gogerald@chromium.org changed reviewers:
+ rouslan@chromium.org, tedchoc@chromium.org

[gogerald1, 2017-01-24 16:46:22]

Hi, rouslan@ and tedchoc@, PTAL,

[gogerald1, 2017-01-24 17:16:14]

PTAL of the new patch 2 with additional comments for public interfaces

[please use gerrit instead, 2017-01-24 17:49:05]

lgtm % nits

https://codereview.chromium.org/2647573005/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java
(right):

https://codereview.chromium.org/2647573005/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java:91:
* @return True If there are Android payment apps on device.
s/If/if/

https://codereview.chromium.org/2647573005/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java:105:
*         map represents an app and the value stores it's name and icon.
s/it's/its/

https://codereview.chromium.org/2647573005/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java:115:
for (ResolveInfo match : matches) {
for (int i = 0.... (more efficient on Android)

https://codereview.chromium.org/2647573005/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2647573005/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:1098:
if (!PaymentPreferences.isPaymentCompleteOnce()) {
nit: single line, if possible

https://codereview.chromium.org/2647573005/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AndroidPaymentAppPreference.java
(right):

https://codereview.chromium.org/2647573005/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AndroidPaymentAppPreference.java:14:
/** ChromeSwitchPreference with fix icon size for Android payment apps. */
s/fix/fixed/

https://codereview.chromium.org/2647573005/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AndroidPaymentAppsFragment.java
(right):

https://codereview.chromium.org/2647573005/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AndroidPaymentAppsFragment.java:53:
// Add a divder line at the bottom of the last preference to separate it from
below
divider

[gogerald1, 2017-01-24 18:08:40]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 18:09:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2017-01-24 18:10:20]

Thanks,

https://codereview.chromium.org/2647573005/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java
(right):

https://codereview.chromium.org/2647573005/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java:91:
* @return True If there are Android payment apps on device.
On 2017/01/24 17:49:04, rouslan wrote:
> s/If/if/

Done.

https://codereview.chromium.org/2647573005/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java:105:
*         map represents an app and the value stores it's name and icon.
On 2017/01/24 17:49:04, rouslan wrote:
> s/it's/its/

Done.

https://codereview.chromium.org/2647573005/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java:115:
for (ResolveInfo match : matches) {
On 2017/01/24 17:49:04, rouslan wrote:
> for (int i = 0.... (more efficient on Android)

Why is more efficient than iterator here? 

We need get(i) later which is O(n) complexity if using 'for(int i=0, ...)',
right?

https://codereview.chromium.org/2647573005/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2647573005/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:1098:
if (!PaymentPreferences.isPaymentCompleteOnce()) {
On 2017/01/24 17:49:04, rouslan wrote:
> nit: single line, if possible

tried, doesn't fit in single line

https://codereview.chromium.org/2647573005/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AndroidPaymentAppPreference.java
(right):

https://codereview.chromium.org/2647573005/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AndroidPaymentAppPreference.java:14:
/** ChromeSwitchPreference with fix icon size for Android payment apps. */
On 2017/01/24 17:49:04, rouslan wrote:
> s/fix/fixed/

Done.

https://codereview.chromium.org/2647573005/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AndroidPaymentAppsFragment.java
(right):

https://codereview.chromium.org/2647573005/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AndroidPaymentAppsFragment.java:53:
// Add a divder line at the bottom of the last preference to separate it from
below
On 2017/01/24 17:49:04, rouslan wrote:
> divider

Done.

[commit-bot: I haz the power, 2017-01-24 19:34:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 19:34:58]

Dry run: This issue passed the CQ dry run.

[Ted C, 2017-01-25 19:05:43]

lgtm w/ small comments

https://codereview.chromium.org/2647573005/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentPreferences.java
(right):

https://codereview.chromium.org/2647573005/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentPreferences.java:10:
public class PaymentPreferences {
I might call this PaymentPreferencesUtil to make it clear that it isn't a
Preference itself.

https://codereview.chromium.org/2647573005/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AndroidPaymentAppsFragment.java
(right):

https://codereview.chromium.org/2647573005/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AndroidPaymentAppsFragment.java:45:
for (Map.Entry<String, Pair<String, Drawable>> app : appsInfo.entrySet()) {
do we want this to be predictably ordered?  Should we order by name?

Wondering if a Map is actually the best here.  Should we use a List of
PaymentAppInfo objects that is ordered by something?

[gogerald1, 2017-01-25 19:43:20]

https://codereview.chromium.org/2647573005/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentPreferences.java
(right):

https://codereview.chromium.org/2647573005/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentPreferences.java:10:
public class PaymentPreferences {
On 2017/01/25 19:05:43, Ted C wrote:
> I might call this PaymentPreferencesUtil to make it clear that it isn't a
> Preference itself.

Done.

https://codereview.chromium.org/2647573005/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AndroidPaymentAppsFragment.java
(right):

https://codereview.chromium.org/2647573005/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AndroidPaymentAppsFragment.java:45:
for (Map.Entry<String, Pair<String, Drawable>> app : appsInfo.entrySet()) {
On 2017/01/25 19:05:43, Ted C wrote:
> do we want this to be predictably ordered?  Should we order by name?
> 
> Wondering if a Map is actually the best here.  Should we use a List of
> PaymentAppInfo objects that is ordered by something?

That's a good idea. Sorting by name also sounds good to me. Will do it in a
separate CL. I am working on sorting payment apps and instruments in payment
request as well.

[gogerald1, 2017-01-25 19:43:26]

The CQ bit was checked by gogerald@chromium.org

[gogerald1, 2017-01-25 19:43:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
rouslan@chromium.org, tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2647573005/#ps160001
(title: "rename")

[commit-bot: I haz the power, 2017-01-25 19:44:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 20:48:49]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1485373406209260,
"parent_rev": "8598442a712230a26347c7adcfc95cbb8e95a46f", "commit_rev":
"81942a0c2161cd39c04dac4368833f8f3ea556ea"}

[commit-bot: I haz the power, 2017-01-25 20:50:30]

Description was changed from

==========
Surface settings UIs to allow users enable and disable Android payment apps in
payment request

The feature is disabled by default. It can be enabled via a flag:

  chrome://flags/#android-payment-apps

To test the new functionality:

  1) Install BobPayWithIsReadyPayService.apk:
    
https://drive.google.com/a/google.com/file/d/0B3ISiXgGE1MNSnFXcnkwQ1FSbGc/vie...
  2) Enable chrome://flags/#android-payment-apps.
  3) Go to setttings/Autofill and payments/Payment apps

BUG=679743

patch from issue 2636023002 at patchset 140001
(http://crrev.com/2636023002#ps140001)
==========

to

==========
Surface settings UIs to allow users enable and disable Android payment apps in
payment request

The feature is disabled by default. It can be enabled via a flag:

  chrome://flags/#android-payment-apps

To test the new functionality:

  1) Install BobPayWithIsReadyPayService.apk:
    
https://drive.google.com/a/google.com/file/d/0B3ISiXgGE1MNSnFXcnkwQ1FSbGc/vie...
  2) Enable chrome://flags/#android-payment-apps.
  3) Go to setttings/Autofill and payments/Payment apps

BUG=679743

patch from issue 2636023002 at patchset 140001
(http://crrev.com/2636023002#ps140001)

Review-Url: https://codereview.chromium.org/2647573005
Cr-Commit-Position: refs/heads/master@{#446111}
Committed:
https://chromium.googlesource.com/chromium/src/+/81942a0c2161cd39c04dac436883...
==========

[commit-bot: I haz the power, 2017-01-25 20:50:36]

Committed patchset #4 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/81942a0c2161cd39c04dac436883...