Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 2647573003: Mark JSArrayBuffer::SetupAllocatingData with WARN_UNUSED_RESULT. (Closed)

Created:
3 years, 11 months ago by jbroman
Modified:
3 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Mark JSArrayBuffer::SetupAllocatingData with WARN_UNUSED_RESULT. Also update a call in cctest to check the result. BUG=chromium:681843 Review-Url: https://codereview.chromium.org/2647573003 Cr-Commit-Position: refs/heads/master@{#42513} Committed: https://chromium.googlesource.com/v8/v8/+/ba2cd16986182ee80973f116ac277b93b7b285bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/objects.h View 1 chunk +6 lines, -4 lines 0 comments Download
M test/cctest/heap/test-page-promotion.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (7 generated)
jbroman
3 years, 11 months ago (2017-01-19 15:58:29 UTC) #4
Jakob Kummerow
LGTM, thanks!
3 years, 11 months ago (2017-01-19 16:02:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647573003/1
3 years, 11 months ago (2017-01-19 16:20:57 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 16:23:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ba2cd16986182ee80973f116ac277b93b7b...

Powered by Google App Engine
This is Rietveld 408576698