Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: src/objects.h

Issue 2647573003: Mark JSArrayBuffer::SetupAllocatingData with WARN_UNUSED_RESULT. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/heap/test-page-promotion.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 9301387c76102a9ee87b5aed821278f12efa583b..4c1a5acb85d55af2c7b2d46bdd43cbe80e9085cf 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -10838,10 +10838,12 @@ class JSArrayBuffer: public JSObject {
void* data, size_t allocated_length,
SharedFlag shared = SharedFlag::kNotShared);
- static bool SetupAllocatingData(Handle<JSArrayBuffer> array_buffer,
- Isolate* isolate, size_t allocated_length,
- bool initialize = true,
- SharedFlag shared = SharedFlag::kNotShared);
+ // Returns false if array buffer contents could not be allocated.
+ // In this case, |array_buffer| will not be set up.
+ static bool SetupAllocatingData(
+ Handle<JSArrayBuffer> array_buffer, Isolate* isolate,
+ size_t allocated_length, bool initialize = true,
+ SharedFlag shared = SharedFlag::kNotShared) WARN_UNUSED_RESULT;
// Dispatched behavior.
DECLARE_PRINTER(JSArrayBuffer)
« no previous file with comments | « no previous file | test/cctest/heap/test-page-promotion.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698