[LayoutNG] Initial pass of removing the state machine from ng_block_layout_algorithm.

[LayoutNG] Initial pass of removing the state machine from ng_block_layout_algorithm.

If followup patches I'll refactor the code to be more readable, this
just removes the state machine in a simple way.

BUG=635619
Review-Url: https://codereview.chromium.org/2647443005
Cr-Commit-Position: refs/heads/master@{#444834}
Committed: https://chromium.googlesource.com/chromium/src/+/01fde50580297be95d015b38d99e6b6d44297fb4

[ikilpatrick, 2017-01-19 17:06:22]

ikilpatrick@chromium.org changed reviewers:
+ cbiesinger@chromium.org

[ikilpatrick, 2017-01-19 17:24:09]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 17:24:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2017-01-19 18:41:11]

lgtm

https://codereview.chromium.org/2647443005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
(right):

https://codereview.chromium.org/2647443005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:229: //
MinAndMaxContentSizes.
Tricky because how do you indicate that it isn't implemented? Or have we decided
that all algorithms need to implement it?

https://codereview.chromium.org/2647443005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:283: if
((position == AbsolutePosition || position == FixedPosition)) {
I know you just moved this but maybe remove one set of parentheses?

[ikilpatrick, 2017-01-19 18:52:43]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 18:53:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2017-01-19 18:54:15]

https://codereview.chromium.org/2647443005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
(right):

https://codereview.chromium.org/2647443005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:229: //
MinAndMaxContentSizes.
On 2017/01/19 18:41:11, cbiesinger wrote:
> Tricky because how do you indicate that it isn't implemented? Or have we
decided
> that all algorithms need to implement it?

I was thinking we could just have a bool NGLayoutAlgorithm::CanUseMinAndMax for
this?

https://codereview.chromium.org/2647443005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:283: if
((position == AbsolutePosition || position == FixedPosition)) {
On 2017/01/19 18:41:11, cbiesinger wrote:
> I know you just moved this but maybe remove one set of parentheses?

Done.

[cbiesinger, 2017-01-19 19:06:30]

lgtm

https://codereview.chromium.org/2647443005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
(right):

https://codereview.chromium.org/2647443005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:229: //
MinAndMaxContentSizes.
On 2017/01/19 18:54:15, ikilpatrick wrote:
> On 2017/01/19 18:41:11, cbiesinger wrote:
> > Tricky because how do you indicate that it isn't implemented? Or have we
> decided
> > that all algorithms need to implement it?
> 
> I was thinking we could just have a bool NGLayoutAlgorithm::CanUseMinAndMax
for
> this? 

True, that works. sounds good.

[ikilpatrick, 2017-01-19 19:21:29]

The CQ bit was unchecked by ikilpatrick@chromium.org

[ikilpatrick, 2017-01-19 19:21:33]

The CQ bit was checked by ikilpatrick@chromium.org

[commit-bot: I haz the power, 2017-01-19 19:22:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 20:22:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484853693116010,
"parent_rev": "34cf6ef588ab528d111fab5efd93e481c5a12d6c", "commit_rev":
"01fde50580297be95d015b38d99e6b6d44297fb4"}

[commit-bot: I haz the power, 2017-01-19 20:23:27]

Description was changed from

==========
[LayoutNG] Initial pass of removing the state machine from
ng_block_layout_algorithm.

If followup patches I'll refactor the code to be more readable, this
just removes the state machine in a simple way.

BUG=635619
==========

to

==========
[LayoutNG] Initial pass of removing the state machine from
ng_block_layout_algorithm.

If followup patches I'll refactor the code to be more readable, this
just removes the state machine in a simple way.

BUG=635619

Review-Url: https://codereview.chromium.org/2647443005
Cr-Commit-Position: refs/heads/master@{#444834}
Committed:
https://chromium.googlesource.com/chromium/src/+/01fde50580297be95d015b38d99e...
==========

[commit-bot: I haz the power, 2017-01-19 20:23:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/01fde50580297be95d015b38d99e...