Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2647353009: Import csswg-test@6212b49508f6272646ac4783fad331ff17031a10 (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
cbiesinger, Manuel Rego
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Import csswg-test@6212b49508f6272646ac4783fad331ff17031a10 Using wpt-import in Chromium 333889f407e49eca681b3354547221022f4d622c. Manual import since csswg-test update has been held up for a few days by other problems with wpt import. This CL also adds a new directory to skip to W3CImportExpectations. TBR=cbiesinger@chromium.org,rego@igalia.com NOEXPORT=true Review-Url: https://codereview.chromium.org/2647353009 Cr-Commit-Position: refs/heads/master@{#446595} Committed: https://chromium.googlesource.com/chromium/src/+/a99fb274b2bcb3660d6ee492b78267bbafef84fb

Patch Set 1 #

Patch Set 2 : Update TestExpectations #

Patch Set 3 : Skip css-values-4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+338 lines, -41 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +41 lines, -40 lines 0 comments Download
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-flow-root-001.html View 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-display-3/display-flow-root-001-expected.html View 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/layout-algorithm_algo-cross-line-001.html View 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/layout-algorithm_algo-cross-line-001-expected.html View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/layout-algorithm_algo-cross-line-002.html View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-flexbox-1/layout-algorithm_algo-cross-line-002-expected.html View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-ui-3/support/cursors/woolly-64.svgz.headers View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-ui-3/text-overflow-005.html View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-ui-3/text-overflow-005-expected.html View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/csswg-test/lint View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/csswg-test/lint.whitelist View 2 chunks +41 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
qyearsley
3 years, 11 months ago (2017-01-26 17:33:49 UTC) #12
qyearsley
Reason for TBR: This should be a fairly straightforward update of csswg-test; the main interesting ...
3 years, 10 months ago (2017-01-27 04:42:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647353009/40001
3 years, 10 months ago (2017-01-27 04:43:01 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/a99fb274b2bcb3660d6ee492b78267bbafef84fb
3 years, 10 months ago (2017-01-27 04:48:23 UTC) #19
Manuel Rego
LGTM. Regarding the Flexbox test, I guess @cbiesinger would take a look. It was added ...
3 years, 10 months ago (2017-01-27 08:52:04 UTC) #20
cbiesinger
3 years, 10 months ago (2017-02-10 21:02:22 UTC) #21
Message was sent while issue was closed.
On 2017/01/27 08:52:04, Manuel Rego wrote:
> LGTM.
> 
> Regarding the Flexbox test, I guess @cbiesinger would take a look.
> It was added in: https://github.com/w3c/csswg-test/pull/1171

Thanks; that test will be fixed by https://codereview.chromium.org/2694463002/

Powered by Google App Engine
This is Rietveld 408576698