[css-flexbox] Correctly size flex rows with scrollbars

[css-flexbox] Correctly size flex rows with scrollbars

Flex items with overflow: scroll were not handled correctly when they *don't*
need to be stretched. We would double-count the scrollbar height.

This also merges constrainedChildIntrinsicContentLogicalHeight into its only
caller, which I think makes the code a bit clearer.

Found thanks to a new W3C test. It also fixes a TODO.

R=eae@chromium.org
BUG=690596
TEST=external/csswg-test/css-flexbox-1/layout-algorithm_algo-cross-line-001.html

Review-Url: https://codereview.chromium.org/2694463002
Cr-Commit-Position: refs/heads/master@{#449902}
Committed: https://chromium.googlesource.com/chromium/src/+/2fbfd7490c876078719caf9867575b9a0826b2ba

[cbiesinger, 2017-02-10 21:00:29]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 21:01:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2017-02-10 21:05:34]

Description was changed from

==========
[css-flexbox] Correctly size flex rows with scrollbars

Flex items with overflow: scroll were not handled correctly when they *don't*
need to be stretched. We would double-count the scrollbar height.

This also merges constrainedChildIntrinsicContentLogicalHeight into its only
caller, which I think makes the code a bit clearer.

Found thanks to a new W3C test.

R=eae@chromium.org
BUG=690596
TEST=external/csswg-test/css-flexbox-1/layout-algorithm_algo-cross-line-001.html
==========

to

==========
[css-flexbox] Correctly size flex rows with scrollbars

Flex items with overflow: scroll were not handled correctly when they *don't*
need to be stretched. We would double-count the scrollbar height.

This also merges constrainedChildIntrinsicContentLogicalHeight into its only
caller, which I think makes the code a bit clearer.

Found thanks to a new W3C test. It also fixes a TODO.

R=eae@chromium.org
BUG=690596
TEST=external/csswg-test/css-flexbox-1/layout-algorithm_algo-cross-line-001.html
==========

[commit-bot: I haz the power, 2017-02-10 22:27:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 22:27:42]

Dry run: This issue passed the CQ dry run.

[eae, 2017-02-12 22:04:25]

LGTM

[cbiesinger1, 2017-02-12 22:25:16]

The CQ bit was checked by cbiesinger@google.com

[commit-bot: I haz the power, 2017-02-12 22:25:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2017-02-12 23:38:37]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-02-12 23:38:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 00:05:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486942717540320, "parent_rev":
"f6eef63c92d7f89f6d4995b5ae24e1b85e6ef755", "commit_rev":
"2fbfd7490c876078719caf9867575b9a0826b2ba"}

[commit-bot: I haz the power, 2017-02-13 00:06:05]

Description was changed from

==========
[css-flexbox] Correctly size flex rows with scrollbars

Flex items with overflow: scroll were not handled correctly when they *don't*
need to be stretched. We would double-count the scrollbar height.

This also merges constrainedChildIntrinsicContentLogicalHeight into its only
caller, which I think makes the code a bit clearer.

Found thanks to a new W3C test. It also fixes a TODO.

R=eae@chromium.org
BUG=690596
TEST=external/csswg-test/css-flexbox-1/layout-algorithm_algo-cross-line-001.html
==========

to

==========
[css-flexbox] Correctly size flex rows with scrollbars

Flex items with overflow: scroll were not handled correctly when they *don't*
need to be stretched. We would double-count the scrollbar height.

This also merges constrainedChildIntrinsicContentLogicalHeight into its only
caller, which I think makes the code a bit clearer.

Found thanks to a new W3C test. It also fixes a TODO.

R=eae@chromium.org
BUG=690596
TEST=external/csswg-test/css-flexbox-1/layout-algorithm_algo-cross-line-001.html

Review-Url: https://codereview.chromium.org/2694463002
Cr-Commit-Position: refs/heads/master@{#449902}
Committed:
https://chromium.googlesource.com/chromium/src/+/2fbfd7490c876078719caf986757...
==========

[commit-bot: I haz the power, 2017-02-13 00:06:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2fbfd7490c876078719caf986757...