|
|
Chromium Code Reviews
DescriptionRemove unnecessary lines from chrome/app/framework.order.
The symbols __ZnwmPv and __ZdlPvS_ are no longer present in the final binary.
BUG=665567
Review-Url: https://codereview.chromium.org/2647343008
Cr-Commit-Position: refs/heads/master@{#446698}
Committed: https://chromium.googlesource.com/chromium/src/+/8cf26ee794a218d356d508521c80bf1e7520076b
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/01/25 19:14:05, erikchen wrote: > The CQ bit was checked by mailto:erikchen@chromium.org to run a CQ dry run Building chrome with gn args: """ dcheck_always_on = false is_component_build = false is_official_build = true is_chrome_branded = true is_debug = false symbol_level = 2 use_goma = true """ shows: """ nm -gjn out/gn/Google\ Chrome\ Framework.framework/Google\ Chrome\ Framework -s __TEXT __text _ChromeAppModeStart_v4 _ChromeMain """
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
erikchen@chromium.org changed reviewers: + mark@chromium.org
mark: Please review. See my earlier comment for output from an official chrome build.
LGTM
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
erikchen@chromium.org changed reviewers: + thakis@chromium.org
thakis: Please rubber-stamp.
lgtm, nice! we were speculating we don't need these in https://codereview.chromium.org/1351143005/diff/20001/chrome/app/framework.or... but I was too chicken to try.
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485536562543100, "parent_rev":
"6f74a028c85e2224bb450ef4f340dc20250cdab8", "commit_rev":
"8cf26ee794a218d356d508521c80bf1e7520076b"}
Message was sent while issue was closed.
Description was changed from ========== Remove unnecessary lines from chrome/app/framework.order. The symbols __ZnwmPv and __ZdlPvS_ are no longer present in the final binary. BUG=665567 ========== to ========== Remove unnecessary lines from chrome/app/framework.order. The symbols __ZnwmPv and __ZdlPvS_ are no longer present in the final binary. BUG=665567 Review-Url: https://codereview.chromium.org/2647343008 Cr-Commit-Position: refs/heads/master@{#446698} Committed: https://chromium.googlesource.com/chromium/src/+/8cf26ee794a218d356d508521c80... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8cf26ee794a218d356d508521c80... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
