Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2647343008: Remove unnecessary lines from chrome/app/framework.order. (Closed)

Created:
3 years, 11 months ago by erikchen
Modified:
3 years, 10 months ago
Reviewers:
Mark Mentovai, Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary lines from chrome/app/framework.order. The symbols __ZnwmPv and __ZdlPvS_ are no longer present in the final binary. BUG=665567 Review-Url: https://codereview.chromium.org/2647343008 Cr-Commit-Position: refs/heads/master@{#446698} Committed: https://chromium.googlesource.com/chromium/src/+/8cf26ee794a218d356d508521c80bf1e7520076b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M chrome/app/framework.order View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
erikchen
On 2017/01/25 19:14:05, erikchen wrote: > The CQ bit was checked by mailto:erikchen@chromium.org to run ...
3 years, 11 months ago (2017-01-25 19:15:44 UTC) #3
erikchen
mark: Please review. See my earlier comment for output from an official chrome build.
3 years, 11 months ago (2017-01-25 23:59:38 UTC) #7
Mark Mentovai
LGTM
3 years, 11 months ago (2017-01-26 23:24:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647343008/1
3 years, 11 months ago (2017-01-26 23:25:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/351532)
3 years, 11 months ago (2017-01-27 00:44:02 UTC) #12
erikchen
thakis: Please rubber-stamp.
3 years, 11 months ago (2017-01-27 02:03:42 UTC) #14
Nico
lgtm, nice! we were speculating we don't need these in https://codereview.chromium.org/1351143005/diff/20001/chrome/app/framework.order#newcode21 but I was too ...
3 years, 11 months ago (2017-01-27 02:12:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647343008/1
3 years, 10 months ago (2017-01-27 17:03:28 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 17:09:20 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8cf26ee794a218d356d508521c80...

Powered by Google App Engine
This is Rietveld 408576698