Chromium Code Reviews Chromium Code Reviews
Issue 1351143005:
mac: Remove a few symbols from framework.order (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 # Copyright (c) 2009 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2009 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 # This .order file defines the order that symbols should be laid out in the | 5 # This .order file defines the order that symbols should be laid out in the |
| 6 # Mac framework. The framework does not contain many global text symbols, and | 6 # Mac framework. The framework does not contain many global text symbols, and |
| 7 # in release mode, does not contain any non-global text symbols after being | 7 # in release mode, does not contain any non-global text symbols after being |
| 8 # stripped. In order to avoid symbolization of stripped binaries from showing | 8 # stripped. In order to avoid symbolization of stripped binaries from showing |
| 9 # confusing offsets from the few public symbols that are available, an | 9 # confusing offsets from the few public symbols that are available, an |
| 10 # easily-recognized symbol, _ChromeMain, is placed last among global text | 10 # easily-recognized symbol, _ChromeMain, is placed last among global text |
| 11 # symbols. | 11 # symbols. |
| 12 # | 12 # |
| 13 # Not all symbols will appear in all build types. Varying optimizations may | 13 # Not all symbols will appear in all build types. Varying optimizations may |
| 14 # result in differences between the set of symbols present in debug and | 14 # result in differences between the set of symbols present in debug and |
| 15 # release modes. When Breakpad is in use, _catch_exception_raise will be | 15 # release modes. When Breakpad is in use, _catch_exception_raise will be |
| 16 # present, but it will not appear in non-Breakpad-enabled builds. It is not | 16 # present, but it will not appear in non-Breakpad-enabled builds. It is not |
| 17 # an error to list symbols in this file that will not be present in each | 17 # an error to list symbols in this file that will not be present in each |
| 18 # output variant. | 18 # output variant. |
| 19 | 19 |
| 20 _NP_GetEntryPoints | |
| 21 _NP_GetMIMEDescription | |
| 22 _NP_GetValue | |
| 23 _NP_Initialize | |
| 24 _NP_Shutdown | |
| 25 __CTFontManagerUnregisterFontForData | 20 __CTFontManagerUnregisterFontForData |
| 26 __ZN7WebCore22narrowPrecisionToFloatIdEEfT_ | |
| 27 __ZN7WebCore24narrowPrecisionToCGFloatIdEEfT_ | |
| 28 __ZnwmPv | 21 __ZnwmPv |
|
Mark Mentovai
2015/09/18 20:15:10
I wonder if we need these two at all.
Nico
2015/09/18 20:24:08
I didn't remove these two. They might be needed on
| |
| 29 __ZdlPvS_ | 22 __ZdlPvS_ |
| 30 _catch_exception_raise | 23 _catch_exception_raise |
|
Mark Mentovai
2015/09/18 20:15:10
We can lose this now too. It was for Breakpad, but
| |
| 31 | 24 |
| 32 # List the gcov symbols so the code coverage bot doesn't trip up in | 25 # List the gcov symbols so the code coverage bot doesn't trip up in |
|
Mark Mentovai
2015/09/18 20:15:10
Since you mentioned that we don’t have a coverage
| |
| 33 # the verify_order post build step. | 26 # the verify_order post build step. |
| 34 ___gcov_init | 27 ___gcov_init |
| 35 ___gcov_seek | 28 ___gcov_seek |
| 36 ___gcov_write_tag_length | 29 ___gcov_write_tag_length |
| 37 ___gcov_write_counter | 30 ___gcov_write_counter |
| 38 ___gcov_write_unsigned | 31 ___gcov_write_unsigned |
| 39 ___gcov_write_summary | 32 ___gcov_write_summary |
| 40 ___gcov_read_counter | 33 ___gcov_read_counter |
| 41 ___gcov_read_unsigned | 34 ___gcov_read_unsigned |
| 42 ___gcov_read_summary | 35 ___gcov_read_summary |
| 43 ___gcov_close | 36 ___gcov_close |
| 44 ___gcov_open | 37 ___gcov_open |
| 45 ___gcov_flush | 38 ___gcov_flush |
| 46 ___gcov_merge_add | 39 ___gcov_merge_add |
| 47 ___gcov_fork | 40 ___gcov_fork |
| 48 | 41 |
| 49 # Provided by build/sanitizers/sanitizer_options.cc in ASan builds. | 42 # Provided by build/sanitizers/sanitizer_options.cc in ASan builds. |
| 50 ___asan_default_options | 43 ___asan_default_options |
| 51 | 44 |
| 52 # Written in asm as a .globl. (Is that necessary?) | |
| 53 _NaClSwitch | |
| 54 _NaClSyscallSeg | |
| 55 | |
| 56 # Entry point from the app mode loader. | 45 # Entry point from the app mode loader. |
| 57 _ChromeAppModeStart | 46 _ChromeAppModeStart |
| 58 | 47 |
| 59 # _ChromeMain must be listed last. That's the whole point of this file. | 48 # _ChromeMain must be listed last. That's the whole point of this file. |
| 60 _ChromeMain | 49 _ChromeMain |
| OLD | NEW |
