Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2647323012: [ReadingList Offline] Handle AMP pages after the rendering delay. (Closed)

Created:
3 years, 11 months ago by Olivier
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[ReadingList Offline] Handle AMP pages after the rendering delay. Google SRP pages are built by javascript and they need time to create the iframe. Navigate to the iframe after the 2 seconds delay. BUG=684554 Review-Url: https://codereview.chromium.org/2649263007 Cr-Commit-Position: refs/heads/master@{#445756} (cherry picked from commit 7cf0a2ae60d21e220291cab0cf3f6579bf933f25) Review-Url: https://codereview.chromium.org/2647323012 . Cr-Commit-Position: refs/branch-heads/2987@{#100} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/b8ca9fcaff83dfb1bfab45006c2bdc2884352c79

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M ios/chrome/browser/reading_list/reading_list_distiller_page.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_distiller_page.mm View 3 chunks +15 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Olivier
3 years, 11 months ago (2017-01-26 08:22:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b8ca9fcaff83dfb1bfab45006c2bdc2884352c79.

Powered by Google App Engine
This is Rietveld 408576698