Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2649263007: [ReadingList Offline] Handle AMP pages after the rendering delay. (Closed)

Created:
3 years, 11 months ago by Olivier
Modified:
3 years, 11 months ago
Reviewers:
jif
CC:
chromium-reviews, marq+watch_chromium.org, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ReadingList Offline] Handle AMP pages after the rendering delay. Google SRP pages are built by javascript and they need time to create the iframe. Navigate to the iframe after the 2 seconds delay. BUG=684554 Review-Url: https://codereview.chromium.org/2649263007 Cr-Commit-Position: refs/heads/master@{#445756} Committed: https://chromium.googlesource.com/chromium/src/+/7cf0a2ae60d21e220291cab0cf3f6579bf933f25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M ios/chrome/browser/reading_list/reading_list_distiller_page.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_distiller_page.mm View 3 chunks +15 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Olivier
3 years, 11 months ago (2017-01-24 16:38:57 UTC) #2
jif
lgtm
3 years, 11 months ago (2017-01-24 17:39:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649263007/1
3 years, 11 months ago (2017-01-24 17:40:23 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 17:51:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7cf0a2ae60d21e220291cab0cf3f...

Powered by Google App Engine
This is Rietveld 408576698