DescriptionAdd extended reporting level in the update request
Step 1: In SafeBrowsingService, determine which extended reporting
preference is set. It could be: OFF, LEGACY, SCOUT, BOTH.
Step 2: ServicesDelegateImpl, proxies that method.
Step 3: Pass a callback to this method to V4LocalDBM, which passes it to
V4UpdateManager.
Step 4: V4UpdateManager calls this callback method when sending a new update
request.
Note that this detection of current extended reporting level is approximate at
best because:
1. We don't have a user profile that the PVer4 updates are tied to. Whereas, the
extneded reporting level is tied to a profile so we report it as enabled if it
is enabled for any of the profiles.
2. The preference can only be checked on the UI thread, whereas we query it on
the task runner so there's a race condition there.
That said, since this is only for reporting, and not for actually sending reports
from user's machine, this approximation is acceptable.
BUG=655802
Review-Url: https://codereview.chromium.org/2647323009
Cr-Commit-Position: refs/heads/master@{#446411}
Committed: https://chromium.googlesource.com/chromium/src/+/0e143114a2eff79cd99bb289ce8956c8c01d675f
Patch Set 1 #
Total comments: 6
Patch Set 2 : Add tests for ERL #
Total comments: 2
Patch Set 3 : Jialiu's feedback #Patch Set 4 : rebase #
Total comments: 2
Patch Set 5 : lpz@ feedback #
Total comments: 2
Patch Set 6 : rebase #Messages
Total messages: 46 (31 generated)
|