Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: chrome/browser/safe_browsing/services_delegate_impl.cc

Issue 2647323009: Add extended reporting level in the update request (Closed)
Patch Set: Add tests for ERL Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/safe_browsing/services_delegate_impl.h" 5 #include "chrome/browser/safe_browsing/services_delegate_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 net::URLRequestContextGetter* context_getter) { 47 net::URLRequestContextGetter* context_getter) {
48 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 48 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
49 #if defined(SAFE_BROWSING_CSD) 49 #if defined(SAFE_BROWSING_CSD)
50 if (!base::CommandLine::ForCurrentProcess()->HasSwitch( 50 if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
51 switches::kDisableClientSidePhishingDetection)) { 51 switches::kDisableClientSidePhishingDetection)) {
52 csd_service_.reset(ClientSideDetectionService::Create(context_getter)); 52 csd_service_.reset(ClientSideDetectionService::Create(context_getter));
53 } 53 }
54 #endif // defined(SAFE_BROWSING_CSD) 54 #endif // defined(SAFE_BROWSING_CSD)
55 } 55 }
56 56
57 ExtendedReportingLevel ServicesDelegateImpl::GetMayBeExtendedReportingLevel()
58 const {
59 if (safe_browsing_service_->maybe_enabled_extended_reporting_by_prefs()) {
Jialiu Lin 2017/01/25 02:03:29 nit: It is possible that both maybe_enabled_extend
vakh (use Gerrit instead) 2017/01/25 02:13:41 Done.
60 // If extended reporting is enabled, report that so that we can track its
61 // usage better for deprecation.
62 return SBER_LEVEL_LEGACY;
63 }
64 if (safe_browsing_service_->maybe_enabled_scout_reporting_by_prefs()) {
65 return SBER_LEVEL_SCOUT;
66 }
67 return SBER_LEVEL_OFF;
68 }
69
57 const scoped_refptr<SafeBrowsingDatabaseManager>& 70 const scoped_refptr<SafeBrowsingDatabaseManager>&
58 ServicesDelegateImpl::v4_local_database_manager() const { 71 ServicesDelegateImpl::v4_local_database_manager() const {
59 return v4_local_database_manager_; 72 return v4_local_database_manager_;
60 } 73 }
61 74
62 void ServicesDelegateImpl::Initialize() { 75 void ServicesDelegateImpl::Initialize() {
63 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 76 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
64 77
65 v4_local_database_manager_ = 78 v4_local_database_manager_ = V4LocalDatabaseManager::Create(
66 V4LocalDatabaseManager::Create(SafeBrowsingService::GetBaseFilename()); 79 SafeBrowsingService::GetBaseFilename(),
80 base::Bind(&ServicesDelegateImpl::GetMayBeExtendedReportingLevel,
81 base::Unretained(this)));
67 82
68 download_service_.reset( 83 download_service_.reset(
69 (services_creator_ && 84 (services_creator_ &&
70 services_creator_->CanCreateDownloadProtectionService()) 85 services_creator_->CanCreateDownloadProtectionService())
71 ? services_creator_->CreateDownloadProtectionService() 86 ? services_creator_->CreateDownloadProtectionService()
72 : CreateDownloadProtectionService()); 87 : CreateDownloadProtectionService());
73 incident_service_.reset( 88 incident_service_.reset(
74 (services_creator_ && 89 (services_creator_ &&
75 services_creator_->CanCreateIncidentReportingService()) 90 services_creator_->CanCreateIncidentReportingService())
76 ? services_creator_->CreateIncidentReportingService() 91 ? services_creator_->CreateIncidentReportingService()
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 } 185 }
171 } 186 }
172 187
173 void ServicesDelegateImpl::StopOnIOThread(bool shutdown) { 188 void ServicesDelegateImpl::StopOnIOThread(bool shutdown) {
174 if (v4_local_database_manager_.get()) { 189 if (v4_local_database_manager_.get()) {
175 v4_local_database_manager_->StopOnIOThread(shutdown); 190 v4_local_database_manager_->StopOnIOThread(shutdown);
176 } 191 }
177 } 192 }
178 193
179 } // namespace safe_browsing 194 } // namespace safe_browsing
OLDNEW
« no previous file with comments | « chrome/browser/safe_browsing/services_delegate_impl.h ('k') | components/safe_browsing_db/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698