Issue 26472004: Revert 227318 "Clean up ResourceHandler API."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26472004: Revert 227318 "Clean up ResourceHandler API." (Closed)

Created:
7 years, 2 months ago by Charlie Reis

Modified:
7 years, 2 months ago

Reviewers:
Charlie Reis

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 227318 "Clean up ResourceHandler API." Could be causing http://crbug.com/305333. > Clean up ResourceHandler API. > > 1. Move URLRequest member to ResourceHandler base class and add convenience functions for subclasses. > 2. Make OnWillRead take a scoped_refptr to avoid leaking the buffer. > > BUG=295239 > TEST=No behavior change. > > Review URL: https://codereview.chromium.org/25536005 TBR=creis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227594

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+193 lines, -211 lines)			Patch
M	trunk/src/content/browser/download/download_resource_handler.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	trunk/src/content/browser/download/download_resource_handler.cc	View	11 chunks	+22 lines, -23 lines	0 comments	Download
M	trunk/src/content/browser/download/save_file_resource_handler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/browser/download/save_file_resource_handler.cc	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	trunk/src/content/browser/loader/async_resource_handler.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	trunk/src/content/browser/loader/async_resource_handler.cc	View	15 chunks	+45 lines, -40 lines	0 comments	Download
M	trunk/src/content/browser/loader/buffered_resource_handler.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	trunk/src/content/browser/loader/buffered_resource_handler.cc	View	14 chunks	+24 lines, -24 lines	0 comments	Download
M	trunk/src/content/browser/loader/certificate_resource_handler.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	trunk/src/content/browser/loader/certificate_resource_handler.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	trunk/src/content/browser/loader/cross_site_resource_handler.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/content/browser/loader/cross_site_resource_handler.cc	View	8 chunks	+14 lines, -10 lines	0 comments	Download
M	trunk/src/content/browser/loader/layered_resource_handler.h	View	2 chunks	+2 lines, -9 lines	0 comments	Download
M	trunk/src/content/browser/loader/layered_resource_handler.cc	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	trunk/src/content/browser/loader/redirect_to_file_resource_handler.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	trunk/src/content/browser/loader/redirect_to_file_resource_handler.cc	View	7 chunks	+13 lines, -12 lines	0 comments	Download
M	trunk/src/content/browser/loader/resource_handler.h	View	4 chunks	+3 lines, -15 lines	0 comments	Download
M	trunk/src/content/browser/loader/resource_handler.cc	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	trunk/src/content/browser/loader/resource_loader.cc	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	trunk/src/content/browser/loader/resource_loader_unittest.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	trunk/src/content/browser/loader/stream_resource_handler.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	trunk/src/content/browser/loader/stream_resource_handler.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/content/browser/loader/sync_resource_handler.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	trunk/src/content/browser/loader/sync_resource_handler.cc	View	5 chunks	+22 lines, -19 lines	0 comments	Download
M	trunk/src/content/browser/loader/throttling_resource_handler.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	trunk/src/content/browser/loader/throttling_resource_handler.cc	View	5 chunks	+10 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r227594.

Expand Messages | Collapse Messages