Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: trunk/src/content/browser/loader/resource_handler.h

Issue 26472004: Revert 227318 "Clean up ResourceHandler API." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/browser/loader/resource_handler.h
===================================================================
--- trunk/src/content/browser/loader/resource_handler.h (revision 227593)
+++ trunk/src/content/browser/loader/resource_handler.h (working copy)
@@ -14,7 +14,6 @@
#include <string>
-#include "base/memory/ref_counted.h"
#include "base/sequenced_task_runner_helpers.h"
#include "base/threading/non_thread_safe.h"
#include "content/common/content_export.h"
@@ -23,14 +22,11 @@
namespace net {
class IOBuffer;
-class URLRequest;
class URLRequestStatus;
} // namespace net
namespace content {
class ResourceController;
-class ResourceMessageFilter;
-class ResourceRequestInfoImpl;
struct ResourceResponse;
// The resource dispatcher host uses this interface to process network events
@@ -81,7 +77,7 @@
// If the handler returns false, then the request is cancelled. Otherwise,
// once data is available, OnReadCompleted will be called.
virtual bool OnWillRead(int request_id,
- scoped_refptr<net::IOBuffer>* buf,
+ net::IOBuffer** buf,
int* buf_size,
int min_size) = 0;
@@ -106,19 +102,11 @@
virtual void OnDataDownloaded(int request_id, int bytes_downloaded) = 0;
protected:
- ResourceHandler(net::URLRequest* request);
+ ResourceHandler() : controller_(NULL) {}
+ ResourceController* controller() { return controller_; }
- ResourceController* controller() const { return controller_; }
- net::URLRequest* request() const { return request_; }
-
- // Convenience functions.
- ResourceRequestInfoImpl* GetRequestInfo() const;
- int GetRequestID() const;
- ResourceMessageFilter* GetFilter() const;
-
private:
ResourceController* controller_;
- net::URLRequest* request_;
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698