Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 25536005: Clean up ResourceHandler API. (Closed)

Created:
7 years, 2 months ago by Charlie Reis
Modified:
7 years, 2 months ago
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka, darin-cc_chromium.org, jam, joi+watch-content_chromium.org
Visibility:
Public.

Description

Clean up ResourceHandler API. 1. Move URLRequest member to ResourceHandler base class and add convenience functions for subclasses. 2. Make OnWillRead take a scoped_refptr to avoid leaking the buffer. BUG=295239 TEST=No behavior change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227318

Patch Set 1 : Initial patch #

Patch Set 2 : Rebase #

Patch Set 3 : Prevent leaks in OnWillRead. #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -193 lines) Patch
M content/browser/download/download_resource_handler.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/download/download_resource_handler.cc View 1 2 11 chunks +23 lines, -22 lines 0 comments Download
M content/browser/download/save_file_resource_handler.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_file_resource_handler.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M content/browser/loader/async_resource_handler.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/loader/async_resource_handler.cc View 1 2 15 chunks +40 lines, -45 lines 0 comments Download
M content/browser/loader/buffered_resource_handler.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/loader/buffered_resource_handler.cc View 1 2 14 chunks +24 lines, -24 lines 0 comments Download
M content/browser/loader/certificate_resource_handler.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/loader/certificate_resource_handler.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/loader/cross_site_resource_handler.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/cross_site_resource_handler.cc View 1 2 8 chunks +10 lines, -14 lines 0 comments Download
M content/browser/loader/layered_resource_handler.h View 1 2 2 chunks +9 lines, -2 lines 0 comments Download
M content/browser/loader/layered_resource_handler.cc View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
M content/browser/loader/redirect_to_file_resource_handler.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/loader/redirect_to_file_resource_handler.cc View 1 2 7 chunks +12 lines, -13 lines 0 comments Download
M content/browser/loader/resource_handler.h View 1 2 4 chunks +15 lines, -3 lines 0 comments Download
M content/browser/loader/resource_handler.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M content/browser/loader/resource_loader.cc View 1 2 2 chunks +5 lines, -7 lines 0 comments Download
M content/browser/loader/resource_loader_unittest.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/loader/stream_resource_handler.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/loader/stream_resource_handler.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/sync_resource_handler.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/loader/sync_resource_handler.cc View 1 2 5 chunks +19 lines, -22 lines 0 comments Download
M content/browser/loader/throttling_resource_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/loader/throttling_resource_handler.cc View 5 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Charlie Reis
Darin, can you take a look? I added convenience functions for all the cases that ...
7 years, 2 months ago (2013-10-01 21:11:23 UTC) #1
Charlie Reis
I've updated this CL to include both the URLRequest cleanup and the scoped_refptr in OnWillStart. ...
7 years, 2 months ago (2013-10-03 18:10:47 UTC) #2
darin (slow to review)
LGTM!!
7 years, 2 months ago (2013-10-04 22:05:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/25536005/13001
7 years, 2 months ago (2013-10-04 22:26:27 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-05 00:10:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/25536005/13001
7 years, 2 months ago (2013-10-07 05:25:48 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-07 06:58:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/25536005/45001
7 years, 2 months ago (2013-10-07 17:28:40 UTC) #8
commit-bot: I haz the power
7 years, 2 months ago (2013-10-07 19:45:55 UTC) #9
Message was sent while issue was closed.
Change committed as 227318

Powered by Google App Engine
This is Rietveld 408576698