Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2647083002: [DevTools] disable frameworks tests for V8 roll (Closed)

Created:
3 years, 11 months ago by kozy
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] disable frameworks tests for V8 roll BUG=chromium:583193 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2647083002 Cr-Commit-Position: refs/heads/master@{#445214} Committed: https://chromium.googlesource.com/chromium/src/+/37570d2ce154da84e0aae0f706f562d531c830ac

Patch Set 1 #

Total comments: 3

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -174 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/debugger/stepping-with-blackboxed-ranges.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html View 1 2 chunks +1 line, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints-expected.txt View 1 9 chunks +8 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-jquery.html View 1 3 chunks +2 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-jquery-expected.txt View 1 3 chunks +16 lines, -28 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-skip-step-in-expected.txt View 1 chunk +5 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-step-from-framework.html View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-step-from-framework-expected.txt View 1 chunk +0 lines, -39 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-steppings.html View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-steppings-expected.txt View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kozy
Dmitry, please take a look.
3 years, 11 months ago (2017-01-20 19:17:16 UTC) #1
kozy
https://codereview.chromium.org/2647083002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html File third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html (left): https://codereview.chromium.org/2647083002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html#oldcode159 third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html:159: "StepOut", "Print", add them back! https://codereview.chromium.org/2647083002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-jquery.html File third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-jquery.html (right): ...
3 years, 11 months ago (2017-01-20 21:59:59 UTC) #2
dgozman
lgtm
3 years, 11 months ago (2017-01-20 22:00:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647083002/20001
3 years, 11 months ago (2017-01-20 22:10:34 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 23:54:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/37570d2ce154da84e0aae0f706f5...

Powered by Google App Engine
This is Rietveld 408576698