third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-steppings.html - Issue 2647083002: [DevTools] disable frameworks tests for V8 roll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-steppings.html

Issue 2647083002: [DevTools] disable frameworks tests for V8 roll (Closed)

Patch Set: addressed comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-steppings-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-steppings.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-steppings.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-steppings.html

index 574e9991a0aa5e0ac71407989d602d315619fe55..1e501b335dbc31c715862a527810d3737c163f13 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-steppings.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-steppings.html

@@ -30,7 +30,7 @@ function callback3()

function callback4()

{

Framework.safeRun(Framework.doSomeWork, function() {

- return 0; // Should NOT step into this callback (otherwise too many StepIns)

+ return 0;

});

try {

Framework.throwFrameworkException("message");

@@ -60,7 +60,8 @@ function test()

"StepInto", "Print", // callback2, skipped

"StepInto", "Print", // callback3

"StepInto", "StepInto", "StepInto", "StepInto", "Print", // callback4

- "StepInto", "Print", // callback4, skipped

+ "StepInto", "Print", // anonymous calback

+ "StepInto", "StepInto", "Print", // callback4, skipped

"StepInto", "Print", // callback4, inside catch

"StepOut", "Print", // return to callback3

"StepOver", "Print", // return to callback2