nogncheck an include guarded under OS_CHROMEOS

nogncheck an include guarded under OS_CHROMEOS

A header guarded under OS_CHROMEOS was added in [1]. It is provided by
the target //components/crash/content/app which is also only used in
chrome/app/mash/BUILD.gn for chromeos. However, this is making gn check
fail under non-chromeos targets e.g. the Linux Ozone bot [2].

This CL addresses the issue with a nogncheck, as it was done in [3].

[1] https://codereview.chromium.org/2643853005
[2] https://build.chromium.org/p/chromium.fyi/builders/Ozone Linux
[3] https://codereview.chromium.org/2620503002/

BUG=585218
Review-Url: https://codereview.chromium.org/2646983002
Cr-Commit-Position: refs/heads/master@{#445159}
Committed: https://chromium.googlesource.com/chromium/src/+/1a33354531479b5530b1a26a72412472b9628efd

[fwang, 2017-01-20 08:55:22]

Description was changed from

==========
nogncheck an include guarded under OS_CHROMEOS

A header guarded under OS_CHROMEOS was added in [1]. It is provided by
the target //components/crash/content/app which is also only used in
chrome/app/mash/BUILD.gn for chromeos. However, this is making gn check
fail under non-chromeos targets e.g. the Linux Ozone bot [2].

This CL addresses the issue with a nogncheck, as it was done in [3].

[1] https://codereview.chromium.org/2643853005
[2] https://build.chromium.org/p/chromium.fyi/builders/Ozone Linux
[3] https://codereview.chromium.org/2620503002/

BUG=585218
==========

to

==========
nogncheck an include guarded under OS_CHROMEOS

A header guarded under OS_CHROMEOS was added in [1]. It is provided by
the target //components/crash/content/app which is also only used in
chrome/app/mash/BUILD.gn for chromeos. However, this is making gn check
fail under non-chromeos targets e.g. the Linux Ozone bot [2].

This CL addresses the issue with a nogncheck, as it was done in [3].

[1] https://codereview.chromium.org/2643853005
[2] https://build.chromium.org/p/chromium.fyi/builders/Ozone Linux
[3] https://codereview.chromium.org/2620503002/

BUG=585218
==========

[fwang, 2017-01-20 08:55:22]

fwang@igalia.com changed reviewers:
+ jamescook@chromium.org, sky@chromium.org

[fwang, 2017-01-20 08:55:33]

PTAL

[tonikitoo, 2017-01-20 15:43:31]

On 2017/01/20 08:55:33, fwang wrote:
> PTAL

informal l g t m.

[James Cook, 2017-01-20 20:22:22]

LGTM. Apologies, it's hard for me to know when gn check will succeed on all
platforms. Out of curiosity, what's the gn config for linux ozone?

[rjkroege, 2017-01-20 20:25:13]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2017-01-20 20:25:33]

The CQ bit was unchecked by rjkroege@chromium.org

[sky, 2017-01-20 20:26:50]

LGTM

[fwang, 2017-01-20 20:28:52]

On 2017/01/20 20:22:22, James Cook (OOO Jan 20) wrote:
> LGTM. Apologies, it's hard for me to know when gn check will succeed on all
> platforms. Out of curiosity, what's the gn config for linux ozone?

No problem.

The config is basically just "use_ozone=true enable_package_mash_services=true"
(https://chromium.googlesource.com/chromium/src/+/master/docs/ozone_overview.m...)

I believe we should really consider making the Ozone Linux bot appear on the
main waterfall. @rjkroege @tomanderson: WDYT?

[fwang, 2017-01-20 20:29:17]

The CQ bit was checked by fwang@igalia.com

[commit-bot: I haz the power, 2017-01-20 20:29:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 21:00:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484944157641040, "parent_rev":
"6701954e9d1f4a50a8b80d888748f7ce78ee82a6", "commit_rev":
"1a33354531479b5530b1a26a72412472b9628efd"}

[commit-bot: I haz the power, 2017-01-20 21:01:06]

Description was changed from

==========
nogncheck an include guarded under OS_CHROMEOS

A header guarded under OS_CHROMEOS was added in [1]. It is provided by
the target //components/crash/content/app which is also only used in
chrome/app/mash/BUILD.gn for chromeos. However, this is making gn check
fail under non-chromeos targets e.g. the Linux Ozone bot [2].

This CL addresses the issue with a nogncheck, as it was done in [3].

[1] https://codereview.chromium.org/2643853005
[2] https://build.chromium.org/p/chromium.fyi/builders/Ozone Linux
[3] https://codereview.chromium.org/2620503002/

BUG=585218
==========

to

==========
nogncheck an include guarded under OS_CHROMEOS

A header guarded under OS_CHROMEOS was added in [1]. It is provided by
the target //components/crash/content/app which is also only used in
chrome/app/mash/BUILD.gn for chromeos. However, this is making gn check
fail under non-chromeos targets e.g. the Linux Ozone bot [2].

This CL addresses the issue with a nogncheck, as it was done in [3].

[1] https://codereview.chromium.org/2643853005
[2] https://build.chromium.org/p/chromium.fyi/builders/Ozone Linux
[3] https://codereview.chromium.org/2620503002/

BUG=585218

Review-Url: https://codereview.chromium.org/2646983002
Cr-Commit-Position: refs/heads/master@{#445159}
Committed:
https://chromium.googlesource.com/chromium/src/+/1a33354531479b5530b1a26a7241...
==========

[commit-bot: I haz the power, 2017-01-20 21:01:07]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1a33354531479b5530b1a26a7241...