Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2646853007: Revert of Use ICCProfile to construct SkColorSpace (Closed)

Created:
3 years, 11 months ago by ccameron
Modified:
3 years, 11 months ago
Reviewers:
esprehn
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, Stephen Chennney, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, kinuko+watch, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use ICCProfile to construct SkColorSpace (patchset #1 id:1 of https://codereview.chromium.org/2644233004/ ) Reason for revert: Broke continuous bots, but not trybots https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/15367 Original issue's description: > Use ICCProfile to construct SkColorSpace > > This is a re-landing of parts of > https://codereview.chromium.org/2605743002/ > > To determine the reason for trybots not matching continuous bots. > > TBR=esprehn > BUG=634102 > > Review-Url: https://codereview.chromium.org/2644233004 > Cr-Commit-Position: refs/heads/master@{#445255} > Committed: https://chromium.googlesource.com/chromium/src/+/a7c18cdafd7db2229539a5e0b5b19c7cb8c6d862 TBR=esprehn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=634102 Review-Url: https://codereview.chromium.org/2646853007 Cr-Commit-Position: refs/heads/master@{#445265} Committed: https://chromium.googlesource.com/chromium/src/+/3d9c9a452905453d023cb1c632ee691ecbde6911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ccameron
Created Revert of Use ICCProfile to construct SkColorSpace
3 years, 11 months ago (2017-01-21 03:32:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646853007/1
3 years, 11 months ago (2017-01-21 03:32:12 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 03:33:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3d9c9a452905453d023cb1c632ee...

Powered by Google App Engine
This is Rietveld 408576698