Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2644233004: Use ICCProfile to construct SkColorSpace (Closed)

Created:
3 years, 11 months ago by ccameron
Modified:
3 years, 11 months ago
Reviewers:
esprehn
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, Stephen Chennney, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, kinuko+watch, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ICCProfile to construct SkColorSpace This is a re-landing of parts of https://codereview.chromium.org/2605743002/ To determine the reason for trybots not matching continuous bots. TBR=esprehn BUG=634102 Review-Url: https://codereview.chromium.org/2644233004 Cr-Commit-Position: refs/heads/master@{#445255} Committed: https://chromium.googlesource.com/chromium/src/+/a7c18cdafd7db2229539a5e0b5b19c7cb8c6d862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644233004/1
3 years, 11 months ago (2017-01-20 20:50:23 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/368087)
3 years, 11 months ago (2017-01-21 00:31:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644233004/1
3 years, 11 months ago (2017-01-21 01:08:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a7c18cdafd7db2229539a5e0b5b19c7cb8c6d862
3 years, 11 months ago (2017-01-21 02:46:15 UTC) #9
ccameron
3 years, 11 months ago (2017-01-21 03:32:00 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2646853007/ by ccameron@chromium.org.

The reason for reverting is: Broke continuous bots, but not trybots
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/build....

Powered by Google App Engine
This is Rietveld 408576698