Fixed synchronization autocomplete unrecoverable error.

Fixed synchronization autocomplete unrecoverable error.

I found the same error as described in a bug with our test accounts. And
I suppose this problem can be as result not correct import autocomplete
entries from the other browsers. For example the import from the firefox
browser doesn't validate name and value fields in autofill entry before
writing it in an autofill table so the browser can import not valid entry
from other browser.
Also the browser doesn't need to cut null terminating symbol in a name
or a value, because the browser generates differ tag for autocomplete
entry and lose link between autocomplete table and local synchronization
database entries.

BUG=596170
Review-Url: https://codereview.chromium.org/2646783002
Cr-Commit-Position: refs/heads/master@{#445348}
Committed: https://chromium.googlesource.com/chromium/src/+/8f5740d76f1f7e60af5a9a0ef118e807a506c7c3

[sath, 2017-01-19 14:44:24]

Description was changed from

==========
Fixed synchronization autocomplete unrecoverable error.

I found the same error as described in a bug with our test accounts. And
I suppose this problem can be as result not correct import autocomplete
entries from the other browsers. For example the import from the firefox
browser doesn't validate name and value fields in autofill entry before
writing it in an autofill table so the browser can import not valid entry
from other browser.
Also the browser doesn't need to cut null terminating symbol in a name
or a value, because the browser generates differ tag for autocomplete
entry and lose link between autocomplete table and local synchronization
database entries.

BUG=596170
==========

to

==========
Fixed synchronization autocomplete unrecoverable error.

I found the same error as described in a bug with our test accounts. And
I suppose this problem can be as result not correct import autocomplete
entries from the other browsers. For example the import from the firefox
browser doesn't validate name and value fields in autofill entry before
writing it in an autofill table so the browser can import not valid entry
from other browser.
Also the browser doesn't need to cut null terminating symbol in a name
or a value, because the browser generates differ tag for autocomplete
entry and lose link between autocomplete table and local synchronization
database entries.

BUG=596170
==========

[sath, 2017-01-19 14:44:24]

sath@yandex-team.ru changed reviewers:
+ estade@chromium.org, gab@chromium.org, pavely@chromium.org

[sath, 2017-01-19 14:44:45]

PTAL

[pavely, 2017-01-20 00:14:12]

lgtm

[Evan Stade, 2017-01-20 01:20:38]

estade@chromium.org changed reviewers:
+ mathp@chromium.org
- estade@chromium.org

[Evan Stade, 2017-01-20 01:20:53]

-estade, +mathp

[gab, 2017-01-20 01:57:15]

Interesting, lgtm

https://codereview.chromium.org/2646783002/diff/20001/chrome/browser/importer...
File chrome/browser/importer/in_process_importer_bridge.cc (right):

https://codereview.chromium.org/2646783002/diff/20001/chrome/browser/importer...
chrome/browser/importer/in_process_importer_bridge.cc:236: base::string16 value
= entries[i].value.c_str();
const on both

[sath, 2017-01-20 10:29:11]

On 2017/01/20 01:57:15, gab (slow at conference) wrote:
> Interesting, lgtm
> 
>
https://codereview.chromium.org/2646783002/diff/20001/chrome/browser/importer...
> File chrome/browser/importer/in_process_importer_bridge.cc (right):
> 
>
https://codereview.chromium.org/2646783002/diff/20001/chrome/browser/importer...
> chrome/browser/importer/in_process_importer_bridge.cc:236: base::string16
value
> = entries[i].value.c_str();
> const on both

done.

[Mathieu, 2017-01-22 20:47:07]

lgtm, thanks

[sath, 2017-01-23 09:46:41]

The CQ bit was checked by sath@yandex-team.ru

[sath, 2017-01-23 09:46:42]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org,
pavely@chromium.org
Link to the patchset: https://codereview.chromium.org/2646783002/#ps40001
(title: "Added const for local variables.")

[commit-bot: I haz the power, 2017-01-23 09:46:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 10:30:01]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485164801612020,
"parent_rev": "22d0a4a5a1e854539fc3f0f2e67e0cfbe35191d9", "commit_rev":
"8f5740d76f1f7e60af5a9a0ef118e807a506c7c3"}

[commit-bot: I haz the power, 2017-01-23 10:30:30]

Description was changed from

==========
Fixed synchronization autocomplete unrecoverable error.

I found the same error as described in a bug with our test accounts. And
I suppose this problem can be as result not correct import autocomplete
entries from the other browsers. For example the import from the firefox
browser doesn't validate name and value fields in autofill entry before
writing it in an autofill table so the browser can import not valid entry
from other browser.
Also the browser doesn't need to cut null terminating symbol in a name
or a value, because the browser generates differ tag for autocomplete
entry and lose link between autocomplete table and local synchronization
database entries.

BUG=596170
==========

to

==========
Fixed synchronization autocomplete unrecoverable error.

I found the same error as described in a bug with our test accounts. And
I suppose this problem can be as result not correct import autocomplete
entries from the other browsers. For example the import from the firefox
browser doesn't validate name and value fields in autofill entry before
writing it in an autofill table so the browser can import not valid entry
from other browser.
Also the browser doesn't need to cut null terminating symbol in a name
or a value, because the browser generates differ tag for autocomplete
entry and lose link between autocomplete table and local synchronization
database entries.

BUG=596170

Review-Url: https://codereview.chromium.org/2646783002
Cr-Commit-Position: refs/heads/master@{#445348}
Committed:
https://chromium.googlesource.com/chromium/src/+/8f5740d76f1f7e60af5a9a0ef118...
==========

[commit-bot: I haz the power, 2017-01-23 10:30:31]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8f5740d76f1f7e60af5a9a0ef118...