Fixed synchronization autocomplete unrecoverable error.

components/autofill/core/browser/webdata/autofill_table_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <map>
 #include <set>
 #include <string>
 #include <tuple>
@@ skipping 67 matching lines @@
     bool (*)(const AutofillEntry&, const AutofillEntry&)> AutofillEntrySet;
 typedef AutofillEntrySet::iterator AutofillEntrySetIterator;
 
 bool CompareAutofillEntries(const AutofillEntry& a, const AutofillEntry& b) {
   return std::tie(a.key().name(), a.key().value(),
                   a.date_created(), a.date_last_used()) <
          std::tie(b.key().name(), b.key().value(),
                   b.date_created(), b.date_last_used());
 }
 
-AutofillEntry MakeAutofillEntry(const char* name,
-                                const char* value,
+AutofillEntry MakeAutofillEntry(const std::string& name,
+                                const std::string& value,
                                 time_t date_created,
                                 time_t date_last_used) {
   if (date_last_used < 0)
     date_last_used = date_created;
   return AutofillEntry(AutofillKey(ASCIIToUTF16(name), ASCIIToUTF16(value)),
                        Time::FromTimeT(date_created),
                        Time::FromTimeT(date_last_used));
 }
 
 // Checks |actual| and |expected| contain the same elements.
@@ skipping 356 matching lines @@
   entries.push_back(entry0);
   entries.push_back(entry1);
   ASSERT_TRUE(table_->UpdateAutofillEntries(entries));
 
   EXPECT_EQ(1, GetAutofillEntryCount(ASCIIToUTF16("foo"), ASCIIToUTF16("bar0"),
                                      db_.get()));
   EXPECT_EQ(2, GetAutofillEntryCount(ASCIIToUTF16("foo"), ASCIIToUTF16("bar1"),
                                      db_.get()));
 }
 
+TEST_F(AutofillTableTest, Autofill_UpdateNullTerminated) {
+  const char kName[] = "foo";
+  const char kValue[] = "bar";
+  // A value which contains terminating character.
+  std::string value(kValue, arraysize(kValue));
+
+  AutofillEntry entry0(MakeAutofillEntry(kName, kValue, 1, -1));
+  AutofillEntry entry1(MakeAutofillEntry(kName, value, 2, 3));
+  std::vector<AutofillEntry> entries;
+  entries.push_back(entry0);
+  entries.push_back(entry1);
+  ASSERT_TRUE(table_->UpdateAutofillEntries(entries));
+
+  EXPECT_EQ(1, GetAutofillEntryCount(ASCIIToUTF16(kName), ASCIIToUTF16(kValue),
+                                     db_.get()));
+  EXPECT_EQ(2, GetAutofillEntryCount(ASCIIToUTF16(kName), ASCIIToUTF16(value),
+                                     db_.get()));
+
+  std::vector<AutofillEntry> all_entries;
+  ASSERT_TRUE(table_->GetAllAutofillEntries(&all_entries));
+  ASSERT_EQ(2U, all_entries.size());
+  EXPECT_EQ(entry0, all_entries[0]);
+  EXPECT_EQ(entry1, all_entries[1]);
+}
+
 TEST_F(AutofillTableTest, Autofill_UpdateReplace) {
   AutofillChangeList changes;
   // Add a form field.  This will be replaced.
   FormFieldData field;
   field.name = ASCIIToUTF16("Name");
   field.value = ASCIIToUTF16("Superman");
   EXPECT_TRUE(table_->AddFormFieldValue(field, &changes));
 
   AutofillEntry entry(MakeAutofillEntry("Name", "Superman", 1, 2));
   std::vector<AutofillEntry> entries;
@@ skipping 1622 matching lines @@
       "(rowid, value) VALUES(1, ?)"));
   s2.BindString(0, "unparseable");
 
   EXPECT_TRUE(s.Run());
   EXPECT_TRUE(s2.Run());
 
   EXPECT_FALSE(table_->GetAllSyncMetadata(syncer::AUTOFILL, &metadata_batch));
 }
 
 }  // namespace autofill