Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2646703002: Remove usage of AsyncExtensionFunction::results_ in system_network_api.cc (Closed)

Created:
3 years, 11 months ago by lazyboy
Modified:
3 years, 11 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of AsyncExtensionFunction::results_ in system_network_api.cc Convert relevant classes to directly inherit from UIThreadExtensionFunction. BUG=648275 Review-Url: https://codereview.chromium.org/2646703002 Cr-Commit-Position: refs/heads/master@{#444903} Committed: https://chromium.googlesource.com/chromium/src/+/fe9846c68f20d9ec068aa960e7700b8c3d9a8d19

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M extensions/browser/api/system_network/system_network_api.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/system_network/system_network_api.cc View 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
lazyboy
Extracted easy bits from https://codereview.chromium.org/2612873004/
3 years, 11 months ago (2017-01-19 03:35:29 UTC) #2
Devlin
lgtm
3 years, 11 months ago (2017-01-20 00:16:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646703002/1
3 years, 11 months ago (2017-01-20 00:40:26 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 00:57:51 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fe9846c68f20d9ec068aa960e770...

Powered by Google App Engine
This is Rietveld 408576698