Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: extensions/browser/api/system_network/system_network_api.cc

Issue 2646703002: Remove usage of AsyncExtensionFunction::results_ in system_network_api.cc (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/system_network/system_network_api.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/system_network/system_network_api.cc
diff --git a/extensions/browser/api/system_network/system_network_api.cc b/extensions/browser/api/system_network/system_network_api.cc
index 38b5a251d77ad9e03b021eca31b7ecc41d4d942a..c2c1f7030fa62d1151f6df2ff95726bfe510c159 100644
--- a/extensions/browser/api/system_network/system_network_api.cc
+++ b/extensions/browser/api/system_network/system_network_api.cc
@@ -19,14 +19,15 @@ SystemNetworkGetNetworkInterfacesFunction::
~SystemNetworkGetNetworkInterfacesFunction() {
}
-bool SystemNetworkGetNetworkInterfacesFunction::RunAsync() {
+ExtensionFunction::ResponseAction
+SystemNetworkGetNetworkInterfacesFunction::Run() {
content::BrowserThread::PostTask(
content::BrowserThread::FILE,
FROM_HERE,
base::Bind(
&SystemNetworkGetNetworkInterfacesFunction::GetListOnFileThread,
this));
- return true;
+ return RespondLater();
}
void SystemNetworkGetNetworkInterfacesFunction::GetListOnFileThread() {
@@ -52,8 +53,7 @@ void SystemNetworkGetNetworkInterfacesFunction::GetListOnFileThread() {
void SystemNetworkGetNetworkInterfacesFunction::HandleGetListError() {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
- error_ = kNetworkListError;
- SendResponse(false);
+ Respond(Error(kNetworkListError));
}
void SystemNetworkGetNetworkInterfacesFunction::SendResponseOnUIThread(
@@ -70,9 +70,8 @@ void SystemNetworkGetNetworkInterfacesFunction::SendResponseOnUIThread(
create_arg.push_back(std::move(info));
}
- results_ =
- api::system_network::GetNetworkInterfaces::Results::Create(create_arg);
- SendResponse(true);
+ Respond(ArgumentList(
+ api::system_network::GetNetworkInterfaces::Results::Create(create_arg)));
}
} // namespace api
« no previous file with comments | « extensions/browser/api/system_network/system_network_api.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698