Fix unused lambda captures.

Fix unused lambda captures.

Clang just got more strict about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in V8.

BUG=chromium:681136
Review-Url: https://codereview.chromium.org/2646553002
Cr-Commit-Position: refs/heads/master@{#42523}
Committed: https://chromium.googlesource.com/v8/v8/+/5ccc719a3169f4b05843cfc69de8e1b9e8e67e7e

[krasin1, 2017-01-18 18:40:09]

The CQ bit was checked by krasin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 18:40:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[krasin1, 2017-01-18 18:41:49]

krasin@chromium.org changed reviewers:
+ machenbach@chromium.org

[krasin1, 2017-01-18 18:41:50]

Hello Michael,

please, review this small pack of fixes to the unused lambda captures. We need
to do this cleanup in order to adapt to the new (more strict) version of Clang.

Generally, not having unused <imports/includes/arguments/lamda captures> is good
anyway.

[commit-bot: I haz the power, 2017-01-18 18:45:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 18:45:23]

Dry run: Try jobs failed on following builders:
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/21172)

[krasin1, 2017-01-18 18:59:52]

Hm... the windows failure makes it the change not as straightforward as I have
thought. I will take time to think about it.

[krasin1, 2017-01-18 18:59:59]

Description was changed from

==========
Fix unused lambda captures.

Clang just got more strict about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in V8.

BUG=chromium:681912
==========

to

==========
Fix unused lambda captures.

Clang just got more strict about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in V8.

BUG=chromium:681912
==========

[krasin1, 2017-01-18 19:00:00]

krasin@chromium.org changed reviewers:
- machenbach@chromium.org

[Michael Achenbach, 2017-01-18 21:14:46]

Please also add some of the directory owners for review. Note that I'm usually
not reviewing V8 src code.

[krasin1, 2017-01-18 22:05:41]

On 2017/01/18 21:14:46, Michael Achenbach wrote:
> Please also add some of the directory owners for review. Note that I'm usually
> not reviewing V8 src code.

Sure. Will do, when we find a proper remedy for the Clang / MSVC++
incompatibility.

[krasin1, 2017-01-19 18:56:14]

The CQ bit was checked by krasin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 18:56:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 19:32:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 19:32:02]

Dry run: This issue passed the CQ dry run.

[krasin1, 2017-01-19 21:10:40]

On 2017/01/18 22:05:41, krasin1 wrote:
> On 2017/01/18 21:14:46, Michael Achenbach wrote:
> > Please also add some of the directory owners for review. Note that I'm
usually
> > not reviewing V8 src code.
> 
> Sure. Will do, when we find a proper remedy for the Clang / MSVC++
> incompatibility.

Update: a simple way to satisfy both compilers is found, the CL is updated and
the dry run succeeded. I will now add the directory owners for review.

[krasin1, 2017-01-19 21:13:25]

krasin@chromium.org changed reviewers:
+ hpayer@chromium.org

[krasin1, 2017-01-19 21:13:25]

Hello Hannes,

this CL fixes a bunch of stack-use-after-scope issues found by AddressSanitizer
with user-after-scope check enabled. Can you please take a look?

If you feel that some parts of the CL are better be reviewed by someone else,
suggestions are welcome.

Thank you very much in advance,
krasin

[Michael Lippautz, 2017-01-19 21:27:15]

On 2017/01/19 21:13:25, krasin1 wrote:
> Hello Hannes,
> 
> this CL fixes a bunch of stack-use-after-scope issues found by
AddressSanitizer
> with user-after-scope check enabled. Can you please take a look?
> 
> If you feel that some parts of the CL are better be reviewed by someone else,
> suggestions are welcome.
> 
> Thank you very much in advance,
> krasin

drive-by lgtm, thanks!

[krasin1, 2017-01-19 21:31:49]

> drive-by lgtm, thanks!

Thank you very much, Michael!

[krasin1, 2017-01-19 21:31:58]

The CQ bit was checked by krasin@chromium.org

[commit-bot: I haz the power, 2017-01-19 21:32:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[krasin1, 2017-01-19 21:33:23]

Description was changed from

==========
Fix unused lambda captures.

Clang just got more strict about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in V8.

BUG=chromium:681912
==========

to

==========
Fix unused lambda captures.

Clang just got more strict about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in V8.

BUG=chromium:681136
==========

[commit-bot: I haz the power, 2017-01-19 21:34:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484861518366750,
"parent_rev": "4e565c68ff0a0fa029852131a324805ec225dcf8", "commit_rev":
"5ccc719a3169f4b05843cfc69de8e1b9e8e67e7e"}

[commit-bot: I haz the power, 2017-01-19 21:34:07]

Description was changed from

==========
Fix unused lambda captures.

Clang just got more strict about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in V8.

BUG=chromium:681136
==========

to

==========
Fix unused lambda captures.

Clang just got more strict about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in V8.

BUG=chromium:681136

Review-Url: https://codereview.chromium.org/2646553002
Cr-Commit-Position: refs/heads/master@{#42523}
Committed:
https://chromium.googlesource.com/v8/v8/+/5ccc719a3169f4b05843cfc69de8e1b9e8e...
==========

[commit-bot: I haz the power, 2017-01-19 21:34:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/5ccc719a3169f4b05843cfc69de8e1b9e8e...