Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/builtins/builtins-array.cc

Issue 2646553002: Fix unused lambda captures. (Closed)
Patch Set: Add a workaround for MSVC++. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/code-stubs.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/builtins/builtins.h" 5 #include "src/builtins/builtins.h"
6 #include "src/builtins/builtins-utils.h" 6 #include "src/builtins/builtins-utils.h"
7 7
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stub-assembler.h" 9 #include "src/code-stub-assembler.h"
10 #include "src/contexts.h" 10 #include "src/contexts.h"
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
311 assembler.SmiConstant(STRICT)); 311 assembler.SmiConstant(STRICT));
312 assembler.Increment(arg_index); 312 assembler.Increment(arg_index);
313 assembler.Goto(&object_push); 313 assembler.Goto(&object_push);
314 } 314 }
315 315
316 // Fallback that stores un-processed arguments using the full, heavyweight 316 // Fallback that stores un-processed arguments using the full, heavyweight
317 // SetProperty machinery. 317 // SetProperty machinery.
318 assembler.Bind(&default_label); 318 assembler.Bind(&default_label);
319 { 319 {
320 args.ForEach( 320 args.ForEach(
321 [&assembler, receiver, context, &arg_index](Node* arg) { 321 [&assembler, receiver, context](Node* arg) {
322 Node* length = assembler.LoadJSArrayLength(receiver); 322 Node* length = assembler.LoadJSArrayLength(receiver);
323 assembler.CallRuntime(Runtime::kSetProperty, context, receiver, 323 assembler.CallRuntime(Runtime::kSetProperty, context, receiver,
324 length, arg, assembler.SmiConstant(STRICT)); 324 length, arg, assembler.SmiConstant(STRICT));
325 }, 325 },
326 arg_index.value()); 326 arg_index.value());
327 args.PopAndReturn(assembler.LoadJSArrayLength(receiver)); 327 args.PopAndReturn(assembler.LoadJSArrayLength(receiver));
328 } 328 }
329 329
330 assembler.Bind(&runtime); 330 assembler.Bind(&runtime);
331 { 331 {
(...skipping 2413 matching lines...) Expand 10 before | Expand all | Expand 10 after
2745 Node* message = assembler.SmiConstant(MessageTemplate::kDetachedOperation); 2745 Node* message = assembler.SmiConstant(MessageTemplate::kDetachedOperation);
2746 Node* result = 2746 Node* result =
2747 assembler.CallRuntime(Runtime::kThrowTypeError, context, message, 2747 assembler.CallRuntime(Runtime::kThrowTypeError, context, message,
2748 assembler.HeapConstant(operation)); 2748 assembler.HeapConstant(operation));
2749 assembler.Return(result); 2749 assembler.Return(result);
2750 } 2750 }
2751 } 2751 }
2752 2752
2753 } // namespace internal 2753 } // namespace internal
2754 } // namespace v8 2754 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698