Use a new Supplement constructor for (Worker)Navigator supplements

Use a new Supplement constructor for (Worker)Navigator supplements

This CL is a step to deprecate the default constructor of Supplement<>.

BUG=610176
Review-Url: https://codereview.chromium.org/2646383002
Cr-Commit-Position: refs/heads/master@{#445350}
Committed: https://chromium.googlesource.com/chromium/src/+/92d389ae2826a4936b6dd6cf1ea69227c8068c6b

[haraken, 2017-01-23 07:59:00]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2017-01-23 07:59:00]

PTAL

[haraken, 2017-01-23 07:59:09]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 07:59:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2017-01-23 08:05:31]

lgtm

https://codereview.chromium.org/2646383002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp (right):

https://codereview.chromium.org/2646383002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp:171:
ContextLifecycleObserver(navigator.frame()->document()),
ftr, crbug.com/683520 suggests that there's a missing null check on
navigator.frame() in this area. 

(The unconditional use of navigator.frame() is in conflict with the conditional
use on the line below.)

[haraken, 2017-01-23 08:11:28]

>
https://codereview.chromium.org/2646383002/diff/1/third_party/WebKit/Source/m...
> File third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp (right):
> 
>
https://codereview.chromium.org/2646383002/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp:171:
> ContextLifecycleObserver(navigator.frame()->document()),
> ftr, crbug.com/683520 suggests that there's a missing null check on
> navigator.frame() in this area. 
> 
> (The unconditional use of navigator.frame() is in conflict with the
conditional
> use on the line below.)

Fixed.

[haraken, 2017-01-23 08:11:37]

The CQ bit was checked by haraken@chromium.org

[haraken, 2017-01-23 08:11:37]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/2646383002/#ps20001
(title: "temp")

[commit-bot: I haz the power, 2017-01-23 08:11:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2017-01-23 08:15:29]

lgtm2

[commit-bot: I haz the power, 2017-01-23 10:41:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485159097174870,
"parent_rev": "3c522c90b1d17cdbacc845d4bd5c931c926143ce", "commit_rev":
"92d389ae2826a4936b6dd6cf1ea69227c8068c6b"}

[commit-bot: I haz the power, 2017-01-23 10:41:44]

Description was changed from

==========
Use a new Supplement constructor for (Worker)Navigator supplements

This CL is a step to deprecate the default constructor of Supplement<>.

BUG=610176
==========

to

==========
Use a new Supplement constructor for (Worker)Navigator supplements

This CL is a step to deprecate the default constructor of Supplement<>.

BUG=610176

Review-Url: https://codereview.chromium.org/2646383002
Cr-Commit-Position: refs/heads/master@{#445350}
Committed:
https://chromium.googlesource.com/chromium/src/+/92d389ae2826a4936b6dd6cf1ea6...
==========

[commit-bot: I haz the power, 2017-01-23 10:41:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/92d389ae2826a4936b6dd6cf1ea6...