Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issue 2646363004: Don't ignore analyzer and dart2js when analyzing fasta. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/fasta
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M pkg/fasta/testing.json View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/testing/lib/src/analyze.dart View 2 chunks +5 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (3 generated)
ahe
3 years, 11 months ago (2017-01-23 11:23:50 UTC) #3
Johnni Winther
lgtm
3 years, 11 months ago (2017-01-23 12:01:32 UTC) #4
ahe
3 years, 11 months ago (2017-01-23 12:28:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
f7796618b474f7f98efb94f7b6ddfd3de1df2a88 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698