Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: pkg/testing/lib/src/analyze.dart

Issue 2646363004: Don't ignore analyzer and dart2js when analyzing fasta. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/fasta/testing.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/testing/lib/src/analyze.dart
diff --git a/pkg/testing/lib/src/analyze.dart b/pkg/testing/lib/src/analyze.dart
index 6106b9ea104db950de9f96f2d2293466312c224d..1a7503aabdb8476cd7a07f90f8190aa96f4b90c6 100644
--- a/pkg/testing/lib/src/analyze.dart
+++ b/pkg/testing/lib/src/analyze.dart
@@ -88,7 +88,8 @@ class AnalyzerDiagnostic {
String toString() {
return "$uri:$line:$startColumn: "
- "${kind == 'INFO' ? 'warning: hint' : kind.toLowerCase()}:\n$message";
+ "${kind == 'INFO' ? 'warning: hint' : kind.toLowerCase()}:\n"
+ "[$code] $message";
}
}
@@ -134,6 +135,9 @@ Future<Null> analyzeUris(
Set<String> seen = new Set<String>();
for (AnalyzerDiagnostic diagnostic in diagnostics) {
String path = diagnostic.uri.path;
+ if (diagnostic.code == "DEPRECATED_MEMBER_USE") continue;
+ if (diagnostic.code == "MISSING_RETURN") continue;
+ if (diagnostic.code == "UNNECESSARY_CAST") continue;
if (exclude.any((RegExp r) => path.contains(r))) continue;
String message = "$diagnostic";
if (seen.add(message)) {
« no previous file with comments | « pkg/fasta/testing.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698