Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2646013003: [Sync] Remove stack upload for an ignorable bookmarks error. (Closed)

Created:
3 years, 11 months ago by maxbogue
Modified:
3 years, 11 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Remove stack upload for an ignorable bookmarks error. There's no reason we should be uploading a stack trace here. We don't even report the error to sync, we just ignore it. BUG=639050 Review-Url: https://codereview.chromium.org/2646013003 Cr-Commit-Position: refs/heads/master@{#445096} Committed: https://chromium.googlesource.com/chromium/src/+/adf0f84df9f461875c97c51de5d1c739d5437c72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M components/sync_bookmarks/bookmark_model_associator.cc View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
maxbogue
Nicolas, PTAL!
3 years, 11 months ago (2017-01-20 00:20:19 UTC) #3
Nicolas Zea
lgtm
3 years, 11 months ago (2017-01-20 18:16:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646013003/1
3 years, 11 months ago (2017-01-20 18:18:37 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 18:23:07 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/adf0f84df9f461875c97c51de5d1...

Powered by Google App Engine
This is Rietveld 408576698