Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: components/sync_bookmarks/bookmark_model_associator.cc

Issue 2646013003: [Sync] Remove stack upload for an ignorable bookmarks error. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync_bookmarks/bookmark_model_associator.cc
diff --git a/components/sync_bookmarks/bookmark_model_associator.cc b/components/sync_bookmarks/bookmark_model_associator.cc
index 8db093d1e03416f36dd40831f0cad769ab69a077..66e8a41ed1866eae98feddf10ba9c7e533f8f990 100644
--- a/components/sync_bookmarks/bookmark_model_associator.cc
+++ b/components/sync_bookmarks/bookmark_model_associator.cc
@@ -755,13 +755,10 @@ const BookmarkNode* BookmarkModelAssociator::CreateBookmarkNode(
const std::string& sync_title = sync_child_node->GetTitle();
if (!sync_child_node->GetIsFolder() && !url.is_valid()) {
- unrecoverable_error_handler_->CreateAndUploadError(
- FROM_HERE,
- "Cannot associate sync node " + sync_child_node->GetSyncId().value() +
- " with invalid url " + url.possibly_invalid_spec() + " and title " +
- sync_title,
- model_type());
- // Don't propagate the error to the model_type in this case.
+ LOG(WARNING) << "Cannot associate sync node "
+ << sync_child_node->GetSyncId().value() << " with invalid url "
+ << url.possibly_invalid_spec() << " and title " << sync_title;
+ // Don't propagate an error to the model_type in this case.
return nullptr;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698