[Service Manager] Get rid of dynamic service discovery

[Service Manager] Get rid of dynamic service discovery

Dynamic service discovery introduces complexity and nondeterminism in
the Service Manager, and its implementation was never quite production-
ready.

This CL removes all of that support, instead requiring a static
service catalog configuration to be provided. Support remains for
dynamic manifest discovery via ManifestProvider in order to satisfy
content layering requirements.

The interesting and interdependent high-level changes covered here:

  - No more Packages directory; service binaries live in root_out_dir
  - Catalog no longer touches disk for any metadata
  - service_manifest and catalog target settings have less redundancy
  - service_manifest and catalog outputs go in the target_gen_dir now
  - service_manifest_overlay behavior has been merged into service_manifest
  - Service Manager may be constructed with a static catalog manifest
  - BackgroundServiceManager no longer owns EDK init/shutdown
  - SM::StartEmbedderService -> SM::RegisterService, more generic API
  - The "service overrides" concept is no longer useful and thus removed
  - All SM embedders, including test suites, are now configured with
    their own static catalog manifest at runtime.

BUG=677194, 672614
TEST=standalone mash_session works, chrome --mash works, mash_browser_tests, various mus and SM-related unit tests all operating normally
TBR=sky@chromium.org
TBR=xhwang@chromium.org

Review-Url: https://codereview.chromium.org/2645973006
Cr-Original-Commit-Position: refs/heads/master@{#445678}
Committed: https://chromium.googlesource.com/chromium/src/+/f5a497cd5ce83519a9c71bd1ef877f85ec022d38
Review-Url: https://codereview.chromium.org/2645973006
Cr-Commit-Position: refs/heads/master@{#445870}
Committed: https://chromium.googlesource.com/chromium/src/+/0a386b5d98de38051e36d314fc43a8a81f913353

[Ken Rockot(use gerrit already), 2017-01-20 21:06:03]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2017-01-20 21:06:08]

rockot@chromium.org changed reviewers:
+ ben@chromium.org

[Ken Rockot(use gerrit already), 2017-01-20 21:06:09]

ta-da

[commit-bot: I haz the power, 2017-01-20 21:06:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-01-20 21:11:17]

Description was changed from

==========
[Service Manager] Get rid of dynamic service discovery

Dynamic service discovery introduces complexity and nondeterminism in
the Service Manager, and its implementation was never quite production-
ready.

This CL removes all of that support, instead requiring a static
service catalog configuration to be provided. Support remains for
dynamic manifest discovery via ManifestProvider in order to satisfy
content layering requirements.

The interesting and interdependent high-level changes covered here:

  - No more Packages directory; service binaries live in root_out_dir
  - Catalog no longer touches disk for any metadata
  - service_manifest and catalog target settings have less redundancy
  - service_manifest and catalog outputs go in the target_gen_dir now
  - service_manifest_overlay behavior has been merged into service_manifest
  - Service Manager may be constructed with a static catalog manifest
  - BackgroundServiceManager no longer owns EDK init/shutdown
  - SM::StartEmbedderService -> SM::RegisterService, more generic API
  - The "service overrides" concept is no longer useful and thus removed
  - All SM embedders, including test suites, are now configured with
    their own static catalog manifest at runtime.

BUG=677194,672614
==========

to

==========
[Service Manager] Get rid of dynamic service discovery

Dynamic service discovery introduces complexity and nondeterminism in
the Service Manager, and its implementation was never quite production-
ready.

This CL removes all of that support, instead requiring a static
service catalog configuration to be provided. Support remains for
dynamic manifest discovery via ManifestProvider in order to satisfy
content layering requirements.

The interesting and interdependent high-level changes covered here:

  - No more Packages directory; service binaries live in root_out_dir
  - Catalog no longer touches disk for any metadata
  - service_manifest and catalog target settings have less redundancy
  - service_manifest and catalog outputs go in the target_gen_dir now
  - service_manifest_overlay behavior has been merged into service_manifest
  - Service Manager may be constructed with a static catalog manifest
  - BackgroundServiceManager no longer owns EDK init/shutdown
  - SM::StartEmbedderService -> SM::RegisterService, more generic API
  - The "service overrides" concept is no longer useful and thus removed
  - All SM embedders, including test suites, are now configured with
    their own static catalog manifest at runtime.

BUG=677194,672614
TEST=standalone mash_session works, chrome --mash works, mash_browser_tests,
various mus and SM-related unit tests all operating normally
==========

[commit-bot: I haz the power, 2017-01-20 21:11:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 21:11:40]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2017-01-20 21:12:56]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 21:13:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 21:31:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 21:31:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2017-01-20 21:43:22]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 21:43:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 22:16:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 22:16:13]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Ben Goodger (Google), 2017-01-20 22:23:15]

lgtm

https://codereview.chromium.org/2645973006/diff/40001/services/service_manage...
File services/service_manager/public/service_manifest.gni (right):

https://codereview.chromium.org/2645973006/diff/40001/services/service_manage...
services/service_manager/public/service_manifest.gni:27: #       The manifest
template for this service. Must be the name over another
Must be the name of

[Ken Rockot(use gerrit already), 2017-01-20 23:19:47]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 23:20:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 23:26:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 23:26:34]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Ken Rockot(use gerrit already), 2017-01-20 23:28:19]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 23:28:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 00:19:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 00:19:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2017-01-21 01:10:46]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-21 01:11:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 02:17:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 02:17:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2017-01-23 20:13:01]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 20:13:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 20:24:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 20:24:18]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Rockot(use gerrit already), 2017-01-23 20:41:12]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 20:41:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 21:36:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 21:36:03]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Ken Rockot(use gerrit already), 2017-01-23 22:38:06]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 22:39:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-01-23 22:39:17]

Description was changed from

==========
[Service Manager] Get rid of dynamic service discovery

Dynamic service discovery introduces complexity and nondeterminism in
the Service Manager, and its implementation was never quite production-
ready.

This CL removes all of that support, instead requiring a static
service catalog configuration to be provided. Support remains for
dynamic manifest discovery via ManifestProvider in order to satisfy
content layering requirements.

The interesting and interdependent high-level changes covered here:

  - No more Packages directory; service binaries live in root_out_dir
  - Catalog no longer touches disk for any metadata
  - service_manifest and catalog target settings have less redundancy
  - service_manifest and catalog outputs go in the target_gen_dir now
  - service_manifest_overlay behavior has been merged into service_manifest
  - Service Manager may be constructed with a static catalog manifest
  - BackgroundServiceManager no longer owns EDK init/shutdown
  - SM::StartEmbedderService -> SM::RegisterService, more generic API
  - The "service overrides" concept is no longer useful and thus removed
  - All SM embedders, including test suites, are now configured with
    their own static catalog manifest at runtime.

BUG=677194,672614
TEST=standalone mash_session works, chrome --mash works, mash_browser_tests,
various mus and SM-related unit tests all operating normally
==========

to

==========
[Service Manager] Get rid of dynamic service discovery

Dynamic service discovery introduces complexity and nondeterminism in
the Service Manager, and its implementation was never quite production-
ready.

This CL removes all of that support, instead requiring a static
service catalog configuration to be provided. Support remains for
dynamic manifest discovery via ManifestProvider in order to satisfy
content layering requirements.

The interesting and interdependent high-level changes covered here:

  - No more Packages directory; service binaries live in root_out_dir
  - Catalog no longer touches disk for any metadata
  - service_manifest and catalog target settings have less redundancy
  - service_manifest and catalog outputs go in the target_gen_dir now
  - service_manifest_overlay behavior has been merged into service_manifest
  - Service Manager may be constructed with a static catalog manifest
  - BackgroundServiceManager no longer owns EDK init/shutdown
  - SM::StartEmbedderService -> SM::RegisterService, more generic API
  - The "service overrides" concept is no longer useful and thus removed
  - All SM embedders, including test suites, are now configured with
    their own static catalog manifest at runtime.

BUG=677194,672614
TEST=standalone mash_session works, chrome --mash works, mash_browser_tests,
various mus and SM-related unit tests all operating normally
TBR=sky@chromium.org
TBR=xhwang@chromium.org
==========

[Ken Rockot(use gerrit already), 2017-01-23 22:42:46]

TBRing xhwang@ and sky@ as owners of a few affected test suites, just FYI.
Basically, replacing "run_service_tests" with explicit per-suite test runners
which hook up a service catalog just for that suite.

In the future I'm hoping to make this a more automated process at build-time and
then we can iterate back down to a unified test runner impl, but for now,
getting rid of the dynamic manifest loading is a priority.

https://codereview.chromium.org/2645973006/diff/40001/services/service_manage...
File services/service_manager/public/service_manifest.gni (right):

https://codereview.chromium.org/2645973006/diff/40001/services/service_manage...
services/service_manager/public/service_manifest.gni:27: #       The manifest
template for this service. Must be the name over another
On 2017/01/20 at 22:23:15, Ben Goodger (Google) wrote:
> Must be the name of

done

[commit-bot: I haz the power, 2017-01-24 00:20:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 00:20:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2017-01-24 00:22:52]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 00:24:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 01:26:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 01:26:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2017-01-24 02:40:52]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 02:41:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 03:40:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 03:40:57]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Rockot(use gerrit already), 2017-01-24 08:02:41]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-01-24 08:02:41]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2645973006/#ps180001
(title: ".")

[commit-bot: I haz the power, 2017-01-24 08:02:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 08:09:08]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1485244961129100,
"parent_rev": "00349ff6fdc6751b559d5bf89e35f8af7b62c4cb", "commit_rev":
"f5a497cd5ce83519a9c71bd1ef877f85ec022d38"}

[commit-bot: I haz the power, 2017-01-24 08:09:44]

Description was changed from

==========
[Service Manager] Get rid of dynamic service discovery

Dynamic service discovery introduces complexity and nondeterminism in
the Service Manager, and its implementation was never quite production-
ready.

This CL removes all of that support, instead requiring a static
service catalog configuration to be provided. Support remains for
dynamic manifest discovery via ManifestProvider in order to satisfy
content layering requirements.

The interesting and interdependent high-level changes covered here:

  - No more Packages directory; service binaries live in root_out_dir
  - Catalog no longer touches disk for any metadata
  - service_manifest and catalog target settings have less redundancy
  - service_manifest and catalog outputs go in the target_gen_dir now
  - service_manifest_overlay behavior has been merged into service_manifest
  - Service Manager may be constructed with a static catalog manifest
  - BackgroundServiceManager no longer owns EDK init/shutdown
  - SM::StartEmbedderService -> SM::RegisterService, more generic API
  - The "service overrides" concept is no longer useful and thus removed
  - All SM embedders, including test suites, are now configured with
    their own static catalog manifest at runtime.

BUG=677194,672614
TEST=standalone mash_session works, chrome --mash works, mash_browser_tests,
various mus and SM-related unit tests all operating normally
TBR=sky@chromium.org
TBR=xhwang@chromium.org
==========

to

==========
[Service Manager] Get rid of dynamic service discovery

Dynamic service discovery introduces complexity and nondeterminism in
the Service Manager, and its implementation was never quite production-
ready.

This CL removes all of that support, instead requiring a static
service catalog configuration to be provided. Support remains for
dynamic manifest discovery via ManifestProvider in order to satisfy
content layering requirements.

The interesting and interdependent high-level changes covered here:

  - No more Packages directory; service binaries live in root_out_dir
  - Catalog no longer touches disk for any metadata
  - service_manifest and catalog target settings have less redundancy
  - service_manifest and catalog outputs go in the target_gen_dir now
  - service_manifest_overlay behavior has been merged into service_manifest
  - Service Manager may be constructed with a static catalog manifest
  - BackgroundServiceManager no longer owns EDK init/shutdown
  - SM::StartEmbedderService -> SM::RegisterService, more generic API
  - The "service overrides" concept is no longer useful and thus removed
  - All SM embedders, including test suites, are now configured with
    their own static catalog manifest at runtime.

BUG=677194,672614
TEST=standalone mash_session works, chrome --mash works, mash_browser_tests,
various mus and SM-related unit tests all operating normally
TBR=sky@chromium.org
TBR=xhwang@chromium.org

Review-Url: https://codereview.chromium.org/2645973006
Cr-Commit-Position: refs/heads/master@{#445678}
Committed:
https://chromium.googlesource.com/chromium/src/+/f5a497cd5ce83519a9c71bd1ef87...
==========

[commit-bot: I haz the power, 2017-01-24 08:09:46]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/f5a497cd5ce83519a9c71bd1ef87...

[johnme, 2017-01-24 12:05:50]

A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.chromium.org/2651953002/ by johnme@chromium.org.

The reason for reverting is: Seems to have broken content_unittests on both
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg...
and
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tes...

with the following error:

CommandFailedError: Failed to list tests on any device

caused by a crash when listing tests:

[FATAL:catalog.cc(167)] Check failed: result..

[johnme, 2017-01-24 13:14:45]

On 2017/01/24 12:05:50, johnme wrote:
> A revert of this CL (patchset #10 id:180001) has been created in
> https://codereview.chromium.org/2651953002/ by mailto:johnme@chromium.org.
> 
> The reason for reverting is: Seems to have broken content_unittests on both
>
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg...
> and
>
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tes...
> 
> with the following error:
> 
> CommandFailedError: Failed to list tests on any device
> 
> caused by a crash when listing tests:
> 
> [FATAL:catalog.cc(167)] Check failed: result..

In addition to breaking content_unittests, this seems to have broken
components_browsertests, components_unittests, and content_browsertests with
errors like:

No such file or directory:
'/b/c/b/KitKat_Tablet_Tester/src/out/Debug/gen/services/service_manager/manifest.json'

(see
https://build.chromium.org/p/chromium.android/builders/KitKat%20Tablet%20Test...)

[Ken Rockot(use gerrit already), 2017-01-24 16:25:39]

On 2017/01/24 at 13:14:45, johnme wrote:
> On 2017/01/24 12:05:50, johnme wrote:
> > A revert of this CL (patchset #10 id:180001) has been created in
> > https://codereview.chromium.org/2651953002/ by mailto:johnme@chromium.org.
> > 
> > The reason for reverting is: Seems to have broken content_unittests on both
> >
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg...
> > and
> >
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tes...
> > 
> > with the following error:
> > 
> > CommandFailedError: Failed to list tests on any device
> > 
> > caused by a crash when listing tests:
> > 
> > [FATAL:catalog.cc(167)] Check failed: result..
> 
> In addition to breaking content_unittests, this seems to have broken
components_browsertests, components_unittests, and content_browsertests with
errors like:
> 
> No such file or directory:
'/b/c/b/KitKat_Tablet_Tester/src/out/Debug/gen/services/service_manager/manifest.json'
> 
> (see
https://build.chromium.org/p/chromium.android/builders/KitKat%20Tablet%20Test...)

The error on these additional tests seems like a bug in the Android testing
system, not in the CL.

There is a data dependency on a generated file, and it's properly listed by GN
in the target's (e.g. content_browsertests's) runtime_deps. Presumably the list
of runtime_deps is used by catapult to set its expectations about files which
should be on a device during test execution, but clearly some of these files are
not on the device.

[Ken Rockot(use gerrit already), 2017-01-24 17:13:45]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 17:14:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-01-24 17:15:09]

Alright - I've removed the unnecessary runtime_deps and filed
http://crbug.com/684594 to address the fact that they caused a problem in the
first place. Also changed content_unittests to not attempt to load a catalog on
Android, since tests which need it are disabled on Android.

This shouldn't red anything now, so re-landing.

[Ken Rockot(use gerrit already), 2017-01-24 17:15:17]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-01-24 17:15:19]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-01-24 17:15:19]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2645973006/#ps200001
(title: ".")

[commit-bot: I haz the power, 2017-01-24 17:15:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 17:18:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 17:18:38]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Ken Rockot(use gerrit already), 2017-01-24 17:36:15]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 17:36:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-01-24 18:07:16]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 18:07:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 21:55:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 21:55:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2017-01-24 22:41:47]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-01-24 22:41:47]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2645973006/#ps240001
(title: ".")

[commit-bot: I haz the power, 2017-01-24 22:42:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 00:14:40]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1485297707079810,
"parent_rev": "5f91d1754a7ffa39cff9619db090b91b8d1b4a98", "commit_rev":
"0a386b5d98de38051e36d314fc43a8a81f913353"}

[commit-bot: I haz the power, 2017-01-25 00:15:19]

Description was changed from

==========
[Service Manager] Get rid of dynamic service discovery

Dynamic service discovery introduces complexity and nondeterminism in
the Service Manager, and its implementation was never quite production-
ready.

This CL removes all of that support, instead requiring a static
service catalog configuration to be provided. Support remains for
dynamic manifest discovery via ManifestProvider in order to satisfy
content layering requirements.

The interesting and interdependent high-level changes covered here:

  - No more Packages directory; service binaries live in root_out_dir
  - Catalog no longer touches disk for any metadata
  - service_manifest and catalog target settings have less redundancy
  - service_manifest and catalog outputs go in the target_gen_dir now
  - service_manifest_overlay behavior has been merged into service_manifest
  - Service Manager may be constructed with a static catalog manifest
  - BackgroundServiceManager no longer owns EDK init/shutdown
  - SM::StartEmbedderService -> SM::RegisterService, more generic API
  - The "service overrides" concept is no longer useful and thus removed
  - All SM embedders, including test suites, are now configured with
    their own static catalog manifest at runtime.

BUG=677194,672614
TEST=standalone mash_session works, chrome --mash works, mash_browser_tests,
various mus and SM-related unit tests all operating normally
TBR=sky@chromium.org
TBR=xhwang@chromium.org

Review-Url: https://codereview.chromium.org/2645973006
Cr-Commit-Position: refs/heads/master@{#445678}
Committed:
https://chromium.googlesource.com/chromium/src/+/f5a497cd5ce83519a9c71bd1ef87...
==========

to

==========
[Service Manager] Get rid of dynamic service discovery

Dynamic service discovery introduces complexity and nondeterminism in
the Service Manager, and its implementation was never quite production-
ready.

This CL removes all of that support, instead requiring a static
service catalog configuration to be provided. Support remains for
dynamic manifest discovery via ManifestProvider in order to satisfy
content layering requirements.

The interesting and interdependent high-level changes covered here:

  - No more Packages directory; service binaries live in root_out_dir
  - Catalog no longer touches disk for any metadata
  - service_manifest and catalog target settings have less redundancy
  - service_manifest and catalog outputs go in the target_gen_dir now
  - service_manifest_overlay behavior has been merged into service_manifest
  - Service Manager may be constructed with a static catalog manifest
  - BackgroundServiceManager no longer owns EDK init/shutdown
  - SM::StartEmbedderService -> SM::RegisterService, more generic API
  - The "service overrides" concept is no longer useful and thus removed
  - All SM embedders, including test suites, are now configured with
    their own static catalog manifest at runtime.

BUG=677194,672614
TEST=standalone mash_session works, chrome --mash works, mash_browser_tests,
various mus and SM-related unit tests all operating normally
TBR=sky@chromium.org
TBR=xhwang@chromium.org

Review-Url: https://codereview.chromium.org/2645973006
Cr-Original-Commit-Position: refs/heads/master@{#445678}
Committed:
https://chromium.googlesource.com/chromium/src/+/f5a497cd5ce83519a9c71bd1ef87...
Review-Url: https://codereview.chromium.org/2645973006
Cr-Commit-Position: refs/heads/master@{#445870}
Committed:
https://chromium.googlesource.com/chromium/src/+/0a386b5d98de38051e36d314fc43...
==========

[commit-bot: I haz the power, 2017-01-25 00:15:22]

Committed patchset #13 (id:240001) as
https://chromium.googlesource.com/chromium/src/+/0a386b5d98de38051e36d314fc43...