Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 2653713004: Add service_test GN template (Closed)

Created:
3 years, 10 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 10 months ago
CC:
blundell+watchlist_chromium.org, chromium-reviews, droger+watchlist_chromium.org, sdefresne+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add service_test GN template Adds a new GN template for unittest suites which run instances of ServiceTest. This integrates static catalog manifest support directly into the build rule, avoiding the need for individual test suites to copy an output catalog and define their own one-off test runner to load it. BUG=672614 Review-Url: https://codereview.chromium.org/2653713004 Cr-Commit-Position: refs/heads/master@{#445961} Committed: https://chromium.googlesource.com/chromium/src/+/26b5760aa847ce3dc92e714a134fb11c5c3548ce

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -460 lines) Patch
M components/filesystem/BUILD.gn View 3 chunks +4 lines, -16 lines 0 comments Download
M components/filesystem/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D components/filesystem/run_all_unittests.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M components/leveldb/BUILD.gn View 1 4 chunks +4 lines, -16 lines 0 comments Download
M components/leveldb/DEPS View 1 1 chunk +0 lines, -7 lines 0 comments Download
D components/leveldb/run_all_unittests.cc View 1 1 chunk +0 lines, -39 lines 0 comments Download
M media/mojo/services/BUILD.gn View 1 2 4 chunks +4 lines, -16 lines 0 comments Download
D media/mojo/services/DEPS View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
D media/mojo/services/run_all_unittests.cc View 1 2 1 chunk +0 lines, -39 lines 0 comments Download
M services/catalog/public/tools/catalog.gni View 1 2 1 chunk +55 lines, -0 lines 0 comments Download
A services/catalog/public/tools/sourcify_manifest.py View 1 chunk +60 lines, -0 lines 0 comments Download
M services/service_manager/public/cpp/test/BUILD.gn View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download
A + services/service_manager/public/cpp/test/DEPS View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
A + services/service_manager/public/cpp/test/run_all_service_tests_with_catalog.cc View 1 2 3 1 chunk +11 lines, -12 lines 0 comments Download
A services/service_manager/public/cpp/test/service_test_catalog.h View 1 chunk +18 lines, -0 lines 0 comments Download
A services/service_manager/public/tools/test/service_test.gni View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download
M services/ui/clipboard/BUILD.gn View 1 2 4 chunks +4 lines, -16 lines 0 comments Download
D services/ui/clipboard/DEPS View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
D services/ui/clipboard/run_all_unittests.cc View 1 2 1 chunk +0 lines, -39 lines 0 comments Download
M services/ui/demo/BUILD.gn View 1 2 4 chunks +4 lines, -16 lines 0 comments Download
M services/ui/demo/DEPS View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
D services/ui/demo/run_all_unittests.cc View 1 2 1 chunk +0 lines, -39 lines 0 comments Download
M services/ui/ime/BUILD.gn View 1 2 4 chunks +4 lines, -16 lines 0 comments Download
D services/ui/ime/DEPS View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
D services/ui/ime/run_all_unittests.cc View 1 2 1 chunk +0 lines, -39 lines 0 comments Download
M services/ui/ws/BUILD.gn View 1 2 7 chunks +4 lines, -18 lines 0 comments Download
M services/ui/ws/DEPS View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
D services/ui/ws/run_all_unittests.cc View 1 2 1 chunk +0 lines, -39 lines 0 comments Download
M ui/views/mus/BUILD.gn View 1 2 5 chunks +4 lines, -11 lines 0 comments Download
M ui/views/mus/views_mus_test_suite.cc View 1 2 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 32 (28 generated)
Ken Rockot(use gerrit already)
Never mind the red, just a patch dependency issue
3 years, 10 months ago (2017-01-24 23:59:58 UTC) #6
Ben Goodger (Google)
lgtm
3 years, 10 months ago (2017-01-25 01:15:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653713004/80001
3 years, 10 months ago (2017-01-25 05:32:23 UTC) #29
commit-bot: I haz the power
3 years, 10 months ago (2017-01-25 05:38:10 UTC) #32
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/26b5760aa847ce3dc92e714a134f...

Powered by Google App Engine
This is Rietveld 408576698