Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2645973004: Have Scrollbar's timer use the same task runner as its scrollable area. (Closed)

Created:
3 years, 11 months ago by jbroman
Modified:
3 years, 11 months ago
Reviewers:
skobes
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have Scrollbar's timer use the same task runner as its scrollable area. This allows the autoscroll timer to be throttled on a per-frame basis. BUG=624694 Review-Url: https://codereview.chromium.org/2645973004 Cr-Commit-Position: refs/heads/master@{#445091} Committed: https://chromium.googlesource.com/chromium/src/+/fe223562c2b41ede75f55b38ad190c54098ac2af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (10 generated)
jbroman
3 years, 11 months ago (2017-01-20 01:50:39 UTC) #4
skobes
lgtm
3 years, 11 months ago (2017-01-20 05:16:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645973004/1
3 years, 11 months ago (2017-01-20 17:55:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/346515)
3 years, 11 months ago (2017-01-20 17:56:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645973004/1
3 years, 11 months ago (2017-01-20 18:05:42 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 18:12:56 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fe223562c2b41ede75f55b38ad19...

Powered by Google App Engine
This is Rietveld 408576698