Move ScrollableArea timer to TaskRunnerTimer.

Move ScrollableArea timer to TaskRunnerTimer.

Choice of task runner is delegated to the subclass, which may know about a
frame-specific timer task runner.

BUG=624694
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2644243002
Cr-Commit-Position: refs/heads/master@{#445084}
Committed: https://chromium.googlesource.com/chromium/src/+/cd5c59cdcc860f2b31f4dea6fd17790559ffb615

[jbroman, 2017-01-20 00:15:27]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[jbroman, 2017-01-20 00:15:28]

Description was changed from

==========
Move ScrollableArea timer to TaskRunnerTimer.

Choice of task runner is delegated to the subclass, which may know about a
frame-specific timer task runner.

BUG=624694
==========

to

==========
Move ScrollableArea timer to TaskRunnerTimer.

Choice of task runner is delegated to the subclass, which may know about a
frame-specific timer task runner.

BUG=624694
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2017-01-20 00:16:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2017-01-20 01:49:40]

jbroman@chromium.org changed reviewers:
+ skobes@chromium.org

[commit-bot: I haz the power, 2017-01-20 02:13:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 02:13:13]

Dry run: This issue passed the CQ dry run.

[jbroman, 2017-01-20 02:47:46]

(cc haraken, in case he feels a different TaskType is appropriate here)

[skobes, 2017-01-20 05:15:38]

lgtm w/ question

https://codereview.chromium.org/2644243002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/RootFrameViewport.h (right):

https://codereview.chromium.org/2644243002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/RootFrameViewport.h:109:
RefPtr<WebTaskRunner> getTimerTaskRunner() const final;
Should we also override this in VisualViewport?

[haraken, 2017-01-20 05:45:51]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2017-01-20 05:45:52]

https://codereview.chromium.org/2644243002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp (right):

https://codereview.chromium.org/2644243002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp:664:
RefPtr<WebTaskRunner> ScrollableArea::getTimerTaskRunner() const {

I'd prefer making this a pure virtual method and override getTimerTaskRunner on
all subclasses.

https://codereview.chromium.org/2644243002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/scroll/ScrollableArea.h (right):

https://codereview.chromium.org/2644243002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scroll/ScrollableArea.h:427:
std::unique_ptr<TimerBase> m_fadeOverlayScrollbarsTimer;

Can we use TimerTaskRunner?

Can we make this TaskTimerRunner<ScrollableArea>?

[jbroman, 2017-01-20 15:52:44]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 15:52:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2017-01-20 15:55:08]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 15:55:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2017-01-20 15:55:17]

https://codereview.chromium.org/2644243002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/RootFrameViewport.h (right):

https://codereview.chromium.org/2644243002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/RootFrameViewport.h:109:
RefPtr<WebTaskRunner> getTimerTaskRunner() const final;
On 2017/01/20 at 05:15:38, skobes wrote:
> Should we also override this in VisualViewport?

Done. (Can the visual viewport have scrollbars? Without them I don't think it
will be called, but combined with haraken's request I've done so.)

https://codereview.chromium.org/2644243002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp (right):

https://codereview.chromium.org/2644243002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp:664:
RefPtr<WebTaskRunner> ScrollableArea::getTimerTaskRunner() const {
On 2017/01/20 at 05:45:51, haraken wrote:
> I'd prefer making this a pure virtual method and override getTimerTaskRunner
on all subclasses.

Done.

https://codereview.chromium.org/2644243002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/scroll/ScrollableArea.h (right):

https://codereview.chromium.org/2644243002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/scroll/ScrollableArea.h:427:
std::unique_ptr<TimerBase> m_fadeOverlayScrollbarsTimer;
On 2017/01/20 at 05:45:51, haraken wrote:
> Can we use TimerTaskRunner?
> 
> Can we make this TaskTimerRunner<ScrollableArea>?

Changed to TaskRunnerTimer<ScrollableArea>.

[jbroman, 2017-01-20 16:00:07]

The CQ bit was unchecked by jbroman@chromium.org

[jbroman, 2017-01-20 16:00:11]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2017-01-20 16:00:11]

The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/2644243002/#ps40001
(title: "use derived class in unique_ptr")

[commit-bot: I haz the power, 2017-01-20 16:00:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-01-20 16:18:29]

LGTM

[commit-bot: I haz the power, 2017-01-20 17:27:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484928011568720,
"parent_rev": "5314b70c4d6d2ae4ed6c7719bc5ac68861409baa", "commit_rev":
"cd5c59cdcc860f2b31f4dea6fd17790559ffb615"}

[commit-bot: I haz the power, 2017-01-20 17:28:16]

Description was changed from

==========
Move ScrollableArea timer to TaskRunnerTimer.

Choice of task runner is delegated to the subclass, which may know about a
frame-specific timer task runner.

BUG=624694
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Move ScrollableArea timer to TaskRunnerTimer.

Choice of task runner is delegated to the subclass, which may know about a
frame-specific timer task runner.

BUG=624694
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2644243002
Cr-Commit-Position: refs/heads/master@{#445084}
Committed:
https://chromium.googlesource.com/chromium/src/+/cd5c59cdcc860f2b31f4dea6fd17...
==========

[commit-bot: I haz the power, 2017-01-20 17:28:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cd5c59cdcc860f2b31f4dea6fd17...