Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2645943003: [serializer] remove test case for internal references. (Closed)

Created:
3 years, 11 months ago by Yang
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] remove test case for internal references. This particular test case is a hack that abuses Turbofan to generate code that contains a switch table. Now that some builtins use the CodeStubAssembler to implement switch tables we don't need this test case anymore. TBR=jarin@chromium.org Review-Url: https://codereview.chromium.org/2645943003 Cr-Commit-Position: refs/heads/master@{#42553} Committed: https://chromium.googlesource.com/v8/v8/+/f40710bce379d29ca2c7ed1f1c35be9a33d73bfb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -90 lines) Patch
M test/cctest/test-serialize.cc View 1 chunk +0 lines, -90 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Yang
3 years, 11 months ago (2017-01-20 12:24:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645943003/1
3 years, 11 months ago (2017-01-20 12:36:58 UTC) #4
Jarin
lgtm. thanks!
3 years, 11 months ago (2017-01-20 12:48:37 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 13:11:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f40710bce379d29ca2c7ed1f1c35be9a33d...

Powered by Google App Engine
This is Rietveld 408576698