Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: test/cctest/test-serialize.cc

Issue 2645943003: [serializer] remove test case for internal references. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-serialize.cc
diff --git a/test/cctest/test-serialize.cc b/test/cctest/test-serialize.cc
index 3da487d09850042972fcd8a7f2e5541f08969c1a..aa91fe5d939a4a3a07464c95a33bd25d417582a3 100644
--- a/test/cctest/test-serialize.cc
+++ b/test/cctest/test-serialize.cc
@@ -1687,96 +1687,6 @@ TEST(CodeSerializerWithHarmonyScoping) {
isolate2->Dispose();
}
-TEST(CodeSerializerInternalReference) {
-#if V8_TARGET_ARCH_ARM || V8_TARGET_ARCH_ARM64
- return;
-#endif
- // In ignition there are only relative jumps, so the following code
- // would not have any internal references. This test is not relevant
- // for ignition.
- if (FLAG_ignition || FLAG_turbo) {
- return;
- }
- // Disable experimental natives that are loaded after deserialization.
- FLAG_function_context_specialization = false;
- FLAG_always_opt = true;
- const char* flag = "--turbo-filter=foo";
- FlagList::SetFlagsFromString(flag, StrLength(flag));
-
- const char* source =
- "var foo = (function(stdlib, foreign, heap) {"
- " function foo(i) {"
- " i = i|0;"
- " var j = 0;"
- " switch (i) {"
- " case 0:"
- " case 1: j = 1; break;"
- " case 2:"
- " case 3: j = 2; break;"
- " case 4:"
- " case 5: j = foo(3) + 1; break;"
- " default: j = 0; break;"
- " }"
- " return j + 10;"
- " }"
- " return { foo: foo };"
- "})(this, {}, undefined).foo;"
- "foo(1);";
-
- v8::StartupData data = v8::V8::CreateSnapshotDataBlob(source);
- CHECK(data.data);
-
- v8::Isolate::CreateParams params;
- params.snapshot_blob = &data;
- params.array_buffer_allocator = CcTest::array_buffer_allocator();
- v8::Isolate* isolate = v8::Isolate::New(params);
- {
- v8::Isolate::Scope i_scope(isolate);
- v8::HandleScope h_scope(isolate);
- v8::Local<v8::Context> context = v8::Context::New(isolate);
- delete[] data.data; // We can dispose of the snapshot blob now.
- v8::Context::Scope c_scope(context);
- v8::Local<v8::Function> foo =
- v8::Local<v8::Function>::Cast(CompileRun("foo"));
-
- // There are at least 6 internal references.
- int mask = RelocInfo::ModeMask(RelocInfo::INTERNAL_REFERENCE) |
- RelocInfo::ModeMask(RelocInfo::INTERNAL_REFERENCE_ENCODED);
- RelocIterator it(
- Handle<JSFunction>::cast(v8::Utils::OpenHandle(*foo))->code(), mask);
- for (int i = 0; i < 6; ++i) {
- CHECK(!it.done());
- it.next();
- }
-
- CHECK(Handle<JSFunction>::cast(v8::Utils::OpenHandle(*foo))
- ->code()
- ->is_turbofanned());
- CHECK_EQ(11, CompileRun("foo(0)")
- ->Int32Value(isolate->GetCurrentContext())
- .FromJust());
- CHECK_EQ(11, CompileRun("foo(1)")
- ->Int32Value(isolate->GetCurrentContext())
- .FromJust());
- CHECK_EQ(12, CompileRun("foo(2)")
- ->Int32Value(isolate->GetCurrentContext())
- .FromJust());
- CHECK_EQ(12, CompileRun("foo(3)")
- ->Int32Value(isolate->GetCurrentContext())
- .FromJust());
- CHECK_EQ(23, CompileRun("foo(4)")
- ->Int32Value(isolate->GetCurrentContext())
- .FromJust());
- CHECK_EQ(23, CompileRun("foo(5)")
- ->Int32Value(isolate->GetCurrentContext())
- .FromJust());
- CHECK_EQ(10, CompileRun("foo(6)")
- ->Int32Value(isolate->GetCurrentContext())
- .FromJust());
- }
- isolate->Dispose();
-}
-
TEST(CodeSerializerEagerCompilationAndPreAge) {
if (FLAG_ignition || FLAG_turbo) return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698