Adjust placement of non-compaction checks.

Adjust placement of non-compaction checks.

The registration of movable objects and their callbacks should be
ignored when running non-compaction GCs. Move the GC kind check one
level out.

At the same time, make these registration methods untyped -- the
Allocator interface for heap collections already provide a typed view,
so unnecessary to extend that one more level.

R=haraken
BUG=

Review-Url: https://codereview.chromium.org/2645873002
Cr-Commit-Position: refs/heads/master@{#444760}
Committed: https://chromium.googlesource.com/chromium/src/+/5e30380b004817803a2bbefe4d8ba9bd6244c935

[sof, 2017-01-19 14:15:42]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 14:16:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2017-01-19 15:25:41]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2017-01-19 15:25:41]

please take a look.

[haraken, 2017-01-19 15:31:41]

LGTM

[commit-bot: I haz the power, 2017-01-19 15:58:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 15:58:30]

Dry run: This issue passed the CQ dry run.

[sof, 2017-01-19 16:20:03]

Description was changed from

==========
Adjust placement of non-compaction checks.

The registration of movable objects and their callbacks should be
ignored when running non-compaction GCs. Move the GC kind check one
level out.

At the same time, make these registration methods untyped -- the
Allocator interface for heap collections already provide a typed view,
so unnecessary to extend that one more level.

R=
BUG=
==========

to

==========
Adjust placement of non-compaction checks.

The registration of movable objects and their callbacks should be
ignored when running non-compaction GCs. Move the GC kind check one
level out.

At the same time, make these registration methods untyped -- the
Allocator interface for heap collections already provide a typed view,
so unnecessary to extend that one more level.

R=haraken
BUG=
==========

[sof, 2017-01-19 16:20:09]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2017-01-19 16:20:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 16:26:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484842809270530, "parent_rev":
"a7aece49f006dc71eb73e924e65f6a44d6a094d9", "commit_rev":
"5e30380b004817803a2bbefe4d8ba9bd6244c935"}

[commit-bot: I haz the power, 2017-01-19 16:27:07]

Description was changed from

==========
Adjust placement of non-compaction checks.

The registration of movable objects and their callbacks should be
ignored when running non-compaction GCs. Move the GC kind check one
level out.

At the same time, make these registration methods untyped -- the
Allocator interface for heap collections already provide a typed view,
so unnecessary to extend that one more level.

R=haraken
BUG=
==========

to

==========
Adjust placement of non-compaction checks.

The registration of movable objects and their callbacks should be
ignored when running non-compaction GCs. Move the GC kind check one
level out.

At the same time, make these registration methods untyped -- the
Allocator interface for heap collections already provide a typed view,
so unnecessary to extend that one more level.

R=haraken
BUG=

Review-Url: https://codereview.chromium.org/2645873002
Cr-Commit-Position: refs/heads/master@{#444760}
Committed:
https://chromium.googlesource.com/chromium/src/+/5e30380b004817803a2bbefe4d8b...
==========

[commit-bot: I haz the power, 2017-01-19 16:27:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5e30380b004817803a2bbefe4d8b...