Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h

Issue 2645873002: Adjust placement of non-compaction checks. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/Visitor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h
diff --git a/third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h b/third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h
index 4b2f56586ef2a20ed9dcb64dc4c2de7709f10298..877fbfd7e81b35adc97513ad3799633b2ff3823c 100644
--- a/third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h
+++ b/third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h
@@ -87,18 +87,16 @@ class MarkingVisitorImpl {
#endif
inline void registerMovingObjectReference(MovableReference* slot) {
- if (toDerived()->getMarkingMode() !=
- VisitorMarkingMode::GlobalMarkingWithCompaction)
- return;
+ DCHECK(toDerived()->getMarkingMode() ==
+ VisitorMarkingMode::GlobalMarkingWithCompaction);
toDerived()->heap().registerMovingObjectReference(slot);
}
inline void registerMovingObjectCallback(MovableReference reference,
MovingObjectCallback callback,
void* callbackData) {
- if (toDerived()->getMarkingMode() !=
- VisitorMarkingMode::GlobalMarkingWithCompaction)
- return;
+ DCHECK(toDerived()->getMarkingMode() ==
+ VisitorMarkingMode::GlobalMarkingWithCompaction);
toDerived()->heap().registerMovingObjectCallback(reference, callback,
callbackData);
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/Visitor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698