Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2645683007: mash: Makes mash and service:ui not establish outgoing connections (Closed)

Created:
3 years, 11 months ago by sky
Modified:
3 years, 11 months ago
Reviewers:
Hadi
CC:
chromium-reviews, rjkroege, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Makes mash and service:ui not establish outgoing connections The ui service was connecting to chrome for the ime driver. As the ui service is a singleton and chrome isn't, this triggered launching another process of chrome, which we don't want. Turns out having ui connect to chrome for the ime driver is unnecessary as chrome already does this. So, removing the code. Mash was connecting to the chrome for the keyboard service. This is also problematic for similar reasons, so removing it too. Filed bug to have chrome register keyboard with mash. BUG=664267, 662157, 664264, 683192, 683289 TEST=none R=moshayedi@chromium.org Review-Url: https://codereview.chromium.org/2645683007 Cr-Commit-Position: refs/heads/master@{#445172} Committed: https://chromium.googlesource.com/chromium/src/+/1340ff2da37b5fcd669e08842cea9223b325a873

Patch Set 1 #

Patch Set 2 : update catalog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -38 lines) Patch
M ash/mus/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ash/mus/keyboard_ui_mus.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M services/ui/ime/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ime/ime_server_impl.h View 2 chunks +0 lines, -5 lines 0 comments Download
M services/ui/ime/ime_server_impl.cc View 4 chunks +3 lines, -24 lines 0 comments Download
M services/ui/manifest.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
sky
3 years, 11 months ago (2017-01-20 19:28:47 UTC) #1
Hadi
Do we still require "service:catalog" in services/ui/manifest.json?
3 years, 11 months ago (2017-01-20 19:45:15 UTC) #4
sky
On 2017/01/20 19:45:15, Hadi wrote: > Do we still require "service:catalog" in services/ui/manifest.json? We do ...
3 years, 11 months ago (2017-01-20 20:31:10 UTC) #7
Hadi
On 2017/01/20 20:31:10, sky wrote: > On 2017/01/20 19:45:15, Hadi wrote: > > Do we ...
3 years, 11 months ago (2017-01-20 20:42:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645683007/20001
3 years, 11 months ago (2017-01-20 20:44:57 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 21:31:38 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1340ff2da37b5fcd669e08842cea...

Powered by Google App Engine
This is Rietveld 408576698