Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: ash/mus/keyboard_ui_mus.cc

Issue 2645683007: mash: Makes mash and service:ui not establish outgoing connections (Closed)
Patch Set: update catalog Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/mus/BUILD.gn ('k') | services/ui/ime/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/mus/keyboard_ui_mus.cc
diff --git a/ash/mus/keyboard_ui_mus.cc b/ash/mus/keyboard_ui_mus.cc
index 83c85cb7b6af130d0644f92836762b5496f31d8c..244a33a787ad195489ebd48b32d89eb8383a0e73 100644
--- a/ash/mus/keyboard_ui_mus.cc
+++ b/ash/mus/keyboard_ui_mus.cc
@@ -6,18 +6,14 @@
#include "ash/common/keyboard/keyboard_ui_observer.h"
#include "base/memory/ptr_util.h"
-#include "content/public/common/service_names.mojom.h"
#include "services/service_manager/public/cpp/connector.h"
namespace ash {
KeyboardUIMus::KeyboardUIMus(service_manager::Connector* connector)
: is_enabled_(false), observer_binding_(this) {
- if (connector) {
- // TODO(sky): should be something like mojo:keyboard, but need mapping.
- connector->BindInterface(content::mojom::kBrowserServiceName, &keyboard_);
- keyboard_->AddObserver(observer_binding_.CreateInterfacePtrAndBind());
- }
+ // TODO: chrome should register the keyboard interface with ash.
+ // http://crbug.com/683289.
}
KeyboardUIMus::~KeyboardUIMus() {}
« no previous file with comments | « ash/mus/BUILD.gn ('k') | services/ui/ime/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698