[ObjC ARC] Converts components/translate/ios/browser:browser to ARC.

[ObjC ARC] Converts components/translate/ios/browser:browser to ARC.

Automatically generated ARCMigrate commit
Notable issues:
 * added a missing include in translate_collection_view_controller.mm
 * replaced forward declarations with includes to fix compilation

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2645603002
Cr-Commit-Position: refs/heads/master@{#444742}
Committed: https://chromium.googlesource.com/chromium/src/+/e7d87d252342973fcbb09c4cac54720c48e9f1be

[stkhapugin, 2017-01-18 17:36:45]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 17:37:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 17:44:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 17:45:00]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[stkhapugin, 2017-01-18 17:48:27]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 17:48:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-01-18 17:49:41]

Description was changed from

==========
[ObjC ARC] Converts components/translate/ios/browser:browser to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts components/translate/ios/browser:browser to ARC.

Automatically generated ARCMigrate commit
Notable issues:
 * added a missing include in translate_collection_view_controller.mm
 * replaced forward declarations with includes to fix compilation

BUG=624363
TEST=None
==========

[commit-bot: I haz the power, 2017-01-18 18:33:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 18:33:01]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[stkhapugin, 2017-01-18 18:39:46]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 18:40:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 19:43:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 19:43:19]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-01-19 12:23:29]

stkhapugin@chromium.org changed reviewers:
+ droger@chromium.org, noyau@chromium.org

[stkhapugin, 2017-01-19 12:23:30]

PTAL.

droger, I don't know if you're an appropriate owner of components/translate/ios,
feel free to send to another reviewer if you so prefer.

[noyau (Ping after 24h), 2017-01-19 12:33:52]

https://codereview.chromium.org/2645603002/diff/40001/ios/web/public/web_stat...
File ios/web/public/web_state/js/crw_js_injection_manager.h (right):

https://codereview.chromium.org/2645603002/diff/40001/ios/web/public/web_stat...
ios/web/public/web_state/js/crw_js_injection_manager.h:12: 
Why change the @class to an import? Nothing else changed in this file, so it
should not be required?

[droger, 2017-01-19 12:36:29]

components/translate lgtm

[stkhapugin, 2017-01-19 13:53:51]

https://codereview.chromium.org/2645603002/diff/40001/ios/web/public/web_stat...
File ios/web/public/web_state/js/crw_js_injection_manager.h (right):

https://codereview.chromium.org/2645603002/diff/40001/ios/web/public/web_stat...
ios/web/public/web_state/js/crw_js_injection_manager.h:12: 
On 2017/01/19 12:33:52, noyau wrote:
> Why change the @class to an import? Nothing else changed in this file, so it
> should not be required?
Done

[noyau (Ping after 24h), 2017-01-19 14:35:26]

lgtm with comment

https://codereview.chromium.org/2645603002/diff/60001/components/translate/io...
File components/translate/ios/browser/translate_controller.h (right):

https://codereview.chromium.org/2645603002/diff/60001/components/translate/io...
components/translate/ios/browser/translate_controller.h:13: #import
"components/translate/ios/browser/js_translate_manager.h"
I believe this include is not needed, the @class should be sufficient (all uses
in this header are with JsTranslateManager*)

[stkhapugin, 2017-01-19 14:48:00]

https://codereview.chromium.org/2645603002/diff/60001/components/translate/io...
File components/translate/ios/browser/translate_controller.h (right):

https://codereview.chromium.org/2645603002/diff/60001/components/translate/io...
components/translate/ios/browser/translate_controller.h:13: #import
"components/translate/ios/browser/js_translate_manager.h"
On 2017/01/19 14:35:26, noyau wrote:
> I believe this include is not needed, the @class should be sufficient (all
uses
> in this header are with JsTranslateManager*)

Done.

[stkhapugin, 2017-01-19 14:48:04]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-01-19 14:48:05]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org,
noyau@chromium.org
Link to the patchset: https://codereview.chromium.org/2645603002/#ps80001
(title: "Removed include")

[commit-bot: I haz the power, 2017-01-19 14:48:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 15:39:48]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484837284682000,
"parent_rev": "ea906a54b111d36dde5a9b43ffe19c657d740765", "commit_rev":
"e7d87d252342973fcbb09c4cac54720c48e9f1be"}

[commit-bot: I haz the power, 2017-01-19 15:40:19]

Description was changed from

==========
[ObjC ARC] Converts components/translate/ios/browser:browser to ARC.

Automatically generated ARCMigrate commit
Notable issues:
 * added a missing include in translate_collection_view_controller.mm
 * replaced forward declarations with includes to fix compilation

BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts components/translate/ios/browser:browser to ARC.

Automatically generated ARCMigrate commit
Notable issues:
 * added a missing include in translate_collection_view_controller.mm
 * replaced forward declarations with includes to fix compilation

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2645603002
Cr-Commit-Position: refs/heads/master@{#444742}
Committed:
https://chromium.googlesource.com/chromium/src/+/e7d87d252342973fcbb09c4cac54...
==========

[commit-bot: I haz the power, 2017-01-19 15:40:20]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e7d87d252342973fcbb09c4cac54...