Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: components/translate/ios/browser/translate_controller.h

Issue 2645603002: [ObjC ARC] Converts components/translate/ios/browser:browser to ARC. (Closed)
Patch Set: Removed include Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/ios/browser/translate_controller.h
diff --git a/components/translate/ios/browser/translate_controller.h b/components/translate/ios/browser/translate_controller.h
index 6cf848e9ace599c89913e16a5a9392847edbb655..c8556e2eac801fb09900ee4c389152e757203789 100644
--- a/components/translate/ios/browser/translate_controller.h
+++ b/components/translate/ios/browser/translate_controller.h
@@ -8,7 +8,6 @@
#include <string>
#include "base/gtest_prod_util.h"
-#include "base/mac/scoped_nsobject.h"
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "ios/web/public/web_state/web_state_observer.h"
@@ -69,7 +68,7 @@ class TranslateController : public web::WebStateObserver {
// Changes the JsTranslateManager used by this TranslateController.
// Only used for testing.
void SetJsTranslateManagerForTesting(JsTranslateManager* manager) {
- js_manager_.reset([manager retain]);
+ js_manager_ = manager;
}
private:
@@ -95,7 +94,7 @@ class TranslateController : public web::WebStateObserver {
void WebStateDestroyed() override;
Observer* observer_;
- base::scoped_nsobject<JsTranslateManager> js_manager_;
+ JsTranslateManager* js_manager_;
base::WeakPtrFactory<TranslateController> weak_method_factory_;
DISALLOW_COPY_AND_ASSIGN(TranslateController);

Powered by Google App Engine
This is Rietveld 408576698