Import wpt@fd6560f225668e933bfb147ee0e20d5971a0d21f

Import wpt@fd6560f225668e933bfb147ee0e20d5971a0d21f

Using update-w3c-deps in Chromium 37af6af68b5ef43dc3b2d588ea7a2a56a678b351.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7882

TBR=qyearsley@chromium.org
NOEXPORT=true

Review-Url: https://codereview.chromium.org/2645553002
Cr-Commit-Position: refs/heads/master@{#444410}
Committed: https://chromium.googlesource.com/chromium/src/+/070aa336d21e0aa7a3fefa0b049ad638d65524c1

[blink-w3c-test-autoroller, 2017-01-18 15:17:45]

Modify TestExpectations or download new baselines for tests.

[blink-w3c-test-autoroller, 2017-01-18 15:17:53]

The CQ bit was checked by blink-w3c-test-autoroller@chromium.org

[commit-bot: I haz the power, 2017-01-18 15:18:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 17:34:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484752673769710,
"parent_rev": "634697b5871cac5bee8850a965b97e23961fd8c8", "commit_rev":
"070aa336d21e0aa7a3fefa0b049ad638d65524c1"}

[commit-bot: I haz the power, 2017-01-18 17:35:21]

Description was changed from

==========
Import wpt@fd6560f225668e933bfb147ee0e20d5971a0d21f

Using update-w3c-deps in Chromium 37af6af68b5ef43dc3b2d588ea7a2a56a678b351.

Build:
https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller...

TBR=qyearsley@chromium.org
NOEXPORT=true
==========

to

==========
Import wpt@fd6560f225668e933bfb147ee0e20d5971a0d21f

Using update-w3c-deps in Chromium 37af6af68b5ef43dc3b2d588ea7a2a56a678b351.

Build:
https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller...

TBR=qyearsley@chromium.org
NOEXPORT=true

Review-Url: https://codereview.chromium.org/2645553002
Cr-Commit-Position: refs/heads/master@{#444410}
Committed:
https://chromium.googlesource.com/chromium/src/+/070aa336d21e0aa7a3fefa0b049a...
==========

[commit-bot: I haz the power, 2017-01-18 17:35:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/070aa336d21e0aa7a3fefa0b049a...

[qyearsley, 2017-01-18 18:10:35]

lgtm

[tkent, 2017-01-19 04:13:34]

tkent@chromium.org changed reviewers:
+ tkent@chromium.org

[tkent, 2017-01-19 04:13:35]

https://codereview.chromium.org/2645553002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (left):

https://codereview.chromium.org/2645553002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:2029: Bug(dpranke)
external/wpt/service-workers/service-worker/fetch-event-redirect.https.html [
Failure Timeout ]
Removing a flaky entry isn't reasonable.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

[qyearsley, 2017-01-19 04:26:38]

On 2017/01/19 at 04:13:35, tkent wrote:
>
https://codereview.chromium.org/2645553002/diff/20001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/TestExpectations (left):
> 
>
https://codereview.chromium.org/2645553002/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/TestExpectations:2029: Bug(dpranke)
external/wpt/service-workers/service-worker/fetch-event-redirect.https.html [
Failure Timeout ]
> Removing a flaky entry isn't reasonable.
> 
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

You're right, that line definitely shouldn't have been removed.

I think that this might have happened now and not earlier due to
http://crrev.com/2604213002 the issue of whether the
"update-w3c-test-expectations" considers at tests that weren't directly
modified. Maybe it's looking at test results for all tests, including flaky
tests that weren't modified, and removing lines like this :-/ Re-opened
crbug.com/676196.

[qyearsley, 2017-01-19 18:16:44]

On 2017/01/19 at 04:26:38, qyearsley wrote:
> On 2017/01/19 at 04:13:35, tkent wrote:
> >
https://codereview.chromium.org/2645553002/diff/20001/third_party/WebKit/Layo...
> > File third_party/WebKit/LayoutTests/TestExpectations (left):
> > 
> >
https://codereview.chromium.org/2645553002/diff/20001/third_party/WebKit/Layo...
> > third_party/WebKit/LayoutTests/TestExpectations:2029: Bug(dpranke)
external/wpt/service-workers/service-worker/fetch-event-redirect.https.html [
Failure Timeout ]
> > Removing a flaky entry isn't reasonable.
> > 
> >
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...
> 
> You're right, that line definitely shouldn't have been removed.
> 
> I think that this might have happened now and not earlier due to
http://crrev.com/2604213002 the issue of whether the
"update-w3c-test-expectations" considers at tests that weren't directly
modified. Maybe it's looking at test results for all tests, including flaky
tests that weren't modified, and removing lines like this :-/ Re-opened
crbug.com/676196.

Note that this particular line that was removed would have been removed by
https://codereview.chromium.org/2643633002, so I think in this case I don't need
to re-add that line.