Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2643633002: Remove Failure entries for tests which pass with WPTServe. (Closed)

Created:
3 years, 11 months ago by tkent
Modified:
3 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Failure entries for tests which pass with WPTServe. BUG=618366 Review-Url: https://codereview.chromium.org/2643633002 Cr-Commit-Position: refs/heads/master@{#444640} Committed: https://chromium.googlesource.com/chromium/src/+/0524c631c52912ac91c931e720cac0c6330c850e

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : < and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -98 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 4 chunks +6 lines, -98 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
tkent
dpranke@, would you review this please? Some tests don't pass now. Maybe we need rebaseline ...
3 years, 11 months ago (2017-01-18 06:53:05 UTC) #4
tkent
https://codereview.chromium.org/2643633002/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2643633002/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode1926 third_party/WebKit/LayoutTests/TestExpectations:1926: crbug.com/618616 external/wpt/service-workers/service-worker/fetch-event-redirect.https.html [ Pass Timeout ] https://codereview.chromium.org/2634323002/ removed the ...
3 years, 11 months ago (2017-01-18 07:32:55 UTC) #5
tkent
rebase
3 years, 11 months ago (2017-01-19 01:47:20 UTC) #10
Dirk Pranke
lgtm. Bonus points for changing Bug(dpranke) to crbug.com/actual-bug-number :). https://codereview.chromium.org/2643633002/diff/20001/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2643633002/diff/20001/third_party/WebKit/LayoutTests/TestExpectations#newcode130 third_party/WebKit/LayoutTests/TestExpectations:130: ...
3 years, 11 months ago (2017-01-19 02:41:53 UTC) #11
tkent
https://codereview.chromium.org/2643633002/diff/20001/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2643633002/diff/20001/third_party/WebKit/LayoutTests/TestExpectations#newcode130 third_party/WebKit/LayoutTests/TestExpectations:130: crbug.com/6648<50 virtual/display_list_2d_canvas/fast/canvas/canvas-createImageBitmap-webgl.html [ Pass Failure ] On 2017/01/19 at ...
3 years, 11 months ago (2017-01-19 03:15:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643633002/60001
3 years, 11 months ago (2017-01-19 04:15:06 UTC) #21
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 04:23:41 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0524c631c52912ac91c931e720ca...

Powered by Google App Engine
This is Rietveld 408576698