|
|
Chromium Code Reviews|
Created:
3 years, 11 months ago by tkent Modified:
3 years, 11 months ago Reviewers:
Dirk Pranke CC:
blink-reviews, chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove Failure entries for tests which pass with WPTServe.
BUG=618366
Review-Url: https://codereview.chromium.org/2643633002
Cr-Commit-Position: refs/heads/master@{#444640}
Committed: https://chromium.googlesource.com/chromium/src/+/0524c631c52912ac91c931e720cac0c6330c850e
Patch Set 1 #
Total comments: 1
Patch Set 2 : rebase #
Total comments: 2
Patch Set 3 : < and rebase #Messages
Total messages: 24 (17 generated)
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
tkent@chromium.org changed reviewers: + dpranke@chromium.org
dpranke@, would you review this please? Some tests don't pass now. Maybe we need rebaseline for them, and it'll be done separately.
https://codereview.chromium.org/2643633002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2643633002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/TestExpectations:1926: crbug.com/618616 external/wpt/service-workers/service-worker/fetch-event-redirect.https.html [ Pass Timeout ] https://codereview.chromium.org/2634323002/ removed the old entry for this.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
rebase
lgtm. Bonus points for changing Bug(dpranke) to crbug.com/actual-bug-number :). https://codereview.chromium.org/2643633002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2643633002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/TestExpectations:130: crbug.com/6648<50 virtual/display_list_2d_canvas/fast/canvas/canvas-createImageBitmap-webgl.html [ Pass Failure ] Nit: typo in bug number.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2643633002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2643633002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/TestExpectations:130: crbug.com/6648<50 virtual/display_list_2d_canvas/fast/canvas/canvas-createImageBitmap-webgl.html [ Pass Failure ] On 2017/01/19 at 02:41:53, Dirk Pranke wrote: > Nit: typo in bug number. Wow! Will fix.
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Patchset #3 (id:40001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by tkent@chromium.org
The CQ bit was checked by tkent@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2643633002/#ps60001 (title: "< and rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484799289446410,
"parent_rev": "3d62570c946d4dcfb0a562582daa74e804b15d1e", "commit_rev":
"0524c631c52912ac91c931e720cac0c6330c850e"}
Message was sent while issue was closed.
Description was changed from ========== Remove Failure entries for tests which pass with WPTServe. BUG=618366 ========== to ========== Remove Failure entries for tests which pass with WPTServe. BUG=618366 Review-Url: https://codereview.chromium.org/2643633002 Cr-Commit-Position: refs/heads/master@{#444640} Committed: https://chromium.googlesource.com/chromium/src/+/0524c631c52912ac91c931e720ca... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/0524c631c52912ac91c931e720ca... |
