Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 2645543002: Back strongly rooted literals CLs out of the tree for branch cut (Closed)

Created:
3 years, 11 months ago by mvstanton
Modified:
3 years, 11 months ago
Reviewers:
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, rmcilroy, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Back strongly rooted literals CLs out of the tree for branch cut Due to outstanding performance issues, it's safer to revert these changes. Revert "PPC/s390: [TypeFeedbackVector] DeclareGlobals needs a literals array" Revert "[TypeFeedbackVector] DeclareGlobals needs a literals array" Revert "PPC/s390: [builtins] CompileLazy bailed out to the runtime entirely too often." Revert "[builtins] CompileLazy bailed out to the runtime entirely too often." Another CL is to follow that removes the main part of this work (after that revert, performance regressions should disappear. TBR=mstarzinger@chromium.org, leszeks@chromium.org, bmeurer@chromium.org BUG=680637 Review-Url: https://codereview.chromium.org/2645543002 Cr-Commit-Position: refs/heads/master@{#42456} Committed: https://chromium.googlesource.com/v8/v8/+/80c9b69d926932bce723218ed47c311b847c3541

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -118 lines) Patch
M src/builtins/arm/builtins-arm.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/builtins/ppc/builtins-ppc.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 5 chunks +5 lines, -22 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 2 chunks +4 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645543002/1
3 years, 11 months ago (2017-01-18 13:10:45 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 13:40:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/80c9b69d926932bce723218ed47c311b847...

Powered by Google App Engine
This is Rietveld 408576698