Remove CFX_Points, CFX_PointsF in favor of std::vector

Remove CFX_Points, CFX_PointsF in favor of std::vector

CFX_Points was unused.

Review-Url: https://codereview.chromium.org/2645523006
Committed: https://pdfium.googlesource.com/pdfium/+/6db6fbcdee9f1887ac02c647210bd5013358f12d

[Tom Sepez, 2017-01-20 18:56:56]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 18:57:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2017-01-20 18:57:27]

tsepez@chromium.org changed reviewers:
+ npm@chromium.org

[Tom Sepez, 2017-01-20 18:57:28]

npm, for review.

[commit-bot: I haz the power, 2017-01-20 19:20:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 19:20:24]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2017-01-20 19:25:36]

Description was changed from

==========
Remove CFX_Points, CFX_PointsF in favor of std::vector

CFX_Points was unused.
==========

to

==========
Remove CFX_Points, CFX_PointsF in favor of std::vector

CFX_Points was unused.
==========

[Tom Sepez, 2017-01-20 19:25:36]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2017-01-20 19:26:03]

+Dan in case he happens to be around.  Thanks.

[npm, 2017-01-20 19:37:34]

lgtm. Some stuff in CFDE_Path could be simplified a bit, but that can be done in
a followup

https://codereview.chromium.org/2645523006/diff/1/xfa/fde/cfde_path.cpp
File xfa/fde/cfde_path.cpp (right):

https://codereview.chromium.org/2645523006/diff/1/xfa/fde/cfde_path.cpp#newco...
xfa/fde/cfde_path.cpp:114: const CFX_PointF* p = points.data();
Why do we need this variable? points[0] etc could be used

https://codereview.chromium.org/2645523006/diff/1/xfa/fde/cfde_path.cpp#newco...
xfa/fde/cfde_path.cpp:127: for (++p; p <= pEnd - 3; p += 3)
Kind of similarly here, could be simplified

https://codereview.chromium.org/2645523006/diff/1/xfa/fde/cfde_path.cpp#newco...
xfa/fde/cfde_path.cpp:132: std::vector<CFX_PointF>& tangents,
It would be better to have a pointer here

[Tom Sepez, 2017-01-20 20:01:15]

https://codereview.chromium.org/2645523006/diff/1/xfa/fde/cfde_path.cpp
File xfa/fde/cfde_path.cpp (right):

https://codereview.chromium.org/2645523006/diff/1/xfa/fde/cfde_path.cpp#newco...
xfa/fde/cfde_path.cpp:114: const CFX_PointF* p = points.data();
On 2017/01/20 19:37:33, npm wrote:
> Why do we need this variable? points[0] etc could be used

Prolly because in the old way, this avoided a bounds check, but now its just as
efficient.  done.

https://codereview.chromium.org/2645523006/diff/1/xfa/fde/cfde_path.cpp#newco...
xfa/fde/cfde_path.cpp:127: for (++p; p <= pEnd - 3; p += 3)
On 2017/01/20 19:37:33, npm wrote:
> Kind of similarly here, could be simplified

Left as-is to avoid thinking about the logic.

https://codereview.chromium.org/2645523006/diff/1/xfa/fde/cfde_path.cpp#newco...
xfa/fde/cfde_path.cpp:132: std::vector<CFX_PointF>& tangents,
On 2017/01/20 19:37:33, npm wrote:
> It would be better to have a pointer here

Done.

[Tom Sepez, 2017-01-20 20:01:21]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2017-01-20 20:01:22]

The patchset sent to the CQ was uploaded after l-g-t-m from npm@chromium.org
Link to the patchset: https://codereview.chromium.org/2645523006/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2017-01-20 20:01:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 20:22:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484942481762720,
"parent_rev": "bc8dcc3ede286fbcaac3f741c379297cffff0eea", "commit_rev":
"6db6fbcdee9f1887ac02c647210bd5013358f12d"}

[commit-bot: I haz the power, 2017-01-20 20:22:21]

Description was changed from

==========
Remove CFX_Points, CFX_PointsF in favor of std::vector

CFX_Points was unused.
==========

to

==========
Remove CFX_Points, CFX_PointsF in favor of std::vector

CFX_Points was unused.

Review-Url: https://codereview.chromium.org/2645523006
Committed:
https://pdfium.googlesource.com/pdfium/+/6db6fbcdee9f1887ac02c647210bd5013358...
==========

[commit-bot: I haz the power, 2017-01-20 20:22:22]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/6db6fbcdee9f1887ac02c647210bd5013358...